Support cross compiling with prebuilt NASM #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #528 +/- ##
==========================================
- Coverage 95.80% 92.52% -3.28%
==========================================
Files 61 67 +6
Lines 8143 9277 +1134
Branches 0 9277 +9277
==========================================
+ Hits 7801 8584 +783
- Misses 342 422 +80
- Partials 0 271 +271 ☔ View full report in Codecov by Sentry. |
justsmth
force-pushed
the
cross-prebuilt-nasm
branch
2 times, most recently
from
cc1eae4 to
d6b9f1c
Compare
justsmth
changed the title
justsmth
force-pushed
the
cross-prebuilt-nasm
branch
from
d6b9f1c to
3258f02
Compare
darylmartin100
requested review from
samuel40791765
and removed request for
andrewhop
samuel40791765
previously approved these changes
Sep 25, 2024
skmcgrail
reviewed
Sep 26, 2024
Co-authored-by: Sean McGrail <549813+skmcgrail@users.noreply.github.com>
samuel40791765
approved these changes
Sep 26, 2024
skmcgrail
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Description of changes:
Provide an equivalent for
prebuilt-nasm.batfor use on non-Windows build hosts.Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.