Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special configs for Clippy #542

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Sep 27, 2024

Description of changes:

  • Enable/disable lints depending on whether clippy is being used.

Call-outs:

  • With this change, Clippy can only be run using the nightly toolchain. Using the stable toolchain produces the following error:
error[E0554]: `#![feature]` may not be used on the stable release channel
 --> aws-lc-sys/builder/main.rs:6:21
  |
6 | #![cfg_attr(clippy, feature(custom_inner_attributes))]
  |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.52%. Comparing base (c358484) to head (7eb3b47).
Report is 84 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #542      +/-   ##
==========================================
- Coverage   95.80%   92.52%   -3.28%     
==========================================
  Files          61       67       +6     
  Lines        8143     9277    +1134     
  Branches        0     9277    +9277     
==========================================
+ Hits         7801     8584     +783     
- Misses        342      422      +80     
- Partials        0      271     +271     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth force-pushed the ignore-unknown-lints-unless-clippy branch from 5648ef5 to c5e9c0b Compare September 27, 2024 17:54
@justsmth justsmth marked this pull request as ready for review September 27, 2024 18:08
@justsmth justsmth requested a review from a team as a code owner September 27, 2024 18:08
@justsmth justsmth changed the title [DRAFT] Special configs for Clippy Special configs for Clippy Sep 27, 2024
@justsmth justsmth merged commit 8c39b68 into aws:main Sep 30, 2024
231 of 232 checks passed
@justsmth justsmth deleted the ignore-unknown-lints-unless-clippy branch September 30, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants