Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling/logging for Android builds #563

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Oct 9, 2024

Issues:

Addresses #562

Description of changes:

Improvement to Android build:

  • Defer the setting of CMAKE_SYSTEM_NAME and CMAKE_SYSTEM_PROCESSOR to cmake-rs.
  • Log relevant environment variables to help with diagnosis and debugging.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner October 9, 2024 13:30
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.62%. Comparing base (c358484) to head (504c4b2).
Report is 96 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #563      +/-   ##
==========================================
- Coverage   95.80%   92.62%   -3.18%     
==========================================
  Files          61       67       +6     
  Lines        8143     9366    +1223     
  Branches        0     9366    +9366     
==========================================
+ Hits         7801     8675     +874     
- Misses        342      420      +78     
- Partials        0      271     +271     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth merged commit e0beb55 into aws:main Oct 11, 2024
230 of 234 checks passed
@justsmth justsmth deleted the cleanup-android branch October 11, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants