Support for AES CFB (128-bit) mode #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #585 +/- ##
==========================================
- Coverage 95.80% 92.60% -3.20%
==========================================
Files 61 67 +6
Lines 8143 9516 +1373
Branches 0 9516 +9516
==========================================
+ Hits 7801 8812 +1011
- Misses 342 430 +88
- Partials 0 274 +274 ☔ View full report in Codecov by Sentry. |
|
I've tried it with the use case described in #575 and it works as expected 👍🏻 Thanks a lot! |
justsmth
previously approved these changes
Nov 13, 2024
justsmth
approved these changes
Nov 13, 2024
samuel40791765
approved these changes
Nov 13, 2024
Comment on lines
+686
to
+687
| for i in 13..=21 { | ||
| for j in 124..=131 { |
There was a problem hiding this comment.
Sorry if I've asked this before and I've noticed this is used in the other tests as well.
What do these pair of numbers mean and should we abstract them into variables?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves #575
Description of changes:
Adds support for AES cipher feedback 128-bit mode (CFB-128). I was going to also support CFB 1-bit and CFB 8-bit modes but have a smaller concern around being able to support that with the fips feature enabled currently. Need to investigate that further, so we may come back at a later date and add support for those additional bit-mode variants. For now this resolves the requester's needs.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.