-
Notifications
You must be signed in to change notification settings - Fork 85
Build/Test for x86_64-pc-windows-gnullvm #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #702 +/- ##
==========================================
- Coverage 95.80% 92.34% -3.46%
==========================================
Files 61 71 +10
Lines 8143 8972 +829
Branches 0 8972 +8972
==========================================
+ Hits 7801 8285 +484
- Misses 342 418 +76
- Partials 0 269 +269 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f3636ec
to
a62d016
Compare
7bd2114
to
0b70549
Compare
0b70549
to
8f52637
Compare
8f52637
to
d83a790
Compare
430a995
to
e29002d
Compare
@justsmth instead of |
7b3338b
to
b105bca
Compare
I looked into an error log. the problem is that wrong target is passed to clang. I don't know which crate does the build, but for cc-rs it was fixed in 1.1.10 version: rust-lang/cc-rs#1176 obviously downloading llvm won't fix the issue. the solution is to pass proper target x86_64-pc-windows-gnu |
b105bca
to
9b4b968
Compare
we currently dropping support for 32-bit environments. there are no 32-bit packages with aws-lc, so feel free to net test mingw32 |
🎉 First success: https://github.com/aws/aws-lc-rs/actions/runs/14795425060/job/41541411147
Ok, I'll remove that target. Thanks! |
9b4b968
to
ab12308
Compare
small thing to fix
this can be workarounded by downloading gcc-compat which is also named |
the issue above is not reproducible in MSYS2 CI by the way. probably something related with mixed host and target (we usually do host == target build) |
f33a445
to
9434186
Compare
9434186
to
0860f00
Compare
thanks for all work on this! |
Issues:
Addresses: #696
Description of changes:
x86_64-pc-windows-gnullvm
Testing:
CI tests passing: https://github.com/aws/aws-lc-rs/actions/runs/14890896214/job/41822424105?pr=702
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.