Skip to content

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Feb 19, 2025

Issues:

Addresses: #696

Description of changes:

  • Support target: x86_64-pc-windows-gnullvm
  • Add CI testing for target.

Testing:

CI tests passing: https://github.com/aws/aws-lc-rs/actions/runs/14890896214/job/41822424105?pr=702

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.34%. Comparing base (c358484) to head (879bd98).
Report is 217 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #702      +/-   ##
==========================================
- Coverage   95.80%   92.34%   -3.46%     
==========================================
  Files          61       71      +10     
  Lines        8143     8972     +829     
  Branches        0     8972    +8972     
==========================================
+ Hits         7801     8285     +484     
- Misses        342      418      +76     
- Partials        0      269     +269     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth justsmth force-pushed the pc-windows-gnullvm branch 8 times, most recently from 7bd2114 to 0b70549 Compare March 6, 2025 14:35
@justsmth justsmth force-pushed the pc-windows-gnullvm branch from 0b70549 to 8f52637 Compare March 18, 2025 17:39
@justsmth justsmth force-pushed the pc-windows-gnullvm branch from 8f52637 to d83a790 Compare May 2, 2025 11:02
@justsmth justsmth force-pushed the pc-windows-gnullvm branch 2 times, most recently from 430a995 to e29002d Compare May 2, 2025 11:54
@ognevny
Copy link

ognevny commented May 2, 2025

@justsmth instead of clang you should install cc package. it will download proper compilers

@justsmth justsmth force-pushed the pc-windows-gnullvm branch 4 times, most recently from 7b3338b to b105bca Compare May 2, 2025 12:34
@ognevny
Copy link

ognevny commented May 2, 2025

I looked into an error log. the problem is that wrong target is passed to clang. I don't know which crate does the build, but for cc-rs it was fixed in 1.1.10 version: rust-lang/cc-rs#1176

obviously downloading llvm won't fix the issue. the solution is to pass proper target x86_64-pc-windows-gnu

@justsmth justsmth force-pushed the pc-windows-gnullvm branch from b105bca to 9b4b968 Compare May 2, 2025 12:43
@ognevny
Copy link

ognevny commented May 2, 2025

we currently dropping support for 32-bit environments. there are no 32-bit packages with aws-lc, so feel free to net test mingw32

@justsmth
Copy link
Contributor Author

justsmth commented May 2, 2025

🎉 First success: https://github.com/aws/aws-lc-rs/actions/runs/14795425060/job/41541411147

we currently dropping support for 32-bit environments. there are no 32-bit packages with aws-lc, so feel free to net test mingw32

Ok, I'll remove that target. Thanks!

@justsmth justsmth force-pushed the pc-windows-gnullvm branch from 9b4b968 to ab12308 Compare May 2, 2025 12:54
@ognevny
Copy link

ognevny commented May 2, 2025

small thing to fix

warning: Compiler family detection failed due to error: ToolNotFound: failed to find tool "D:\\a\\_temp\\msys64\\clang64\\bin\\g++.exe": The system cannot find the file specified. (os error 2) (see https://docs.rs/cc/latest/cc/#compile-time-requirements for help)

this can be workarounded by downloading gcc-compat which is also named gcc for simplicity. but if it is just a warning and actual compiler family is detected then there is nothing to do

@ognevny
Copy link

ognevny commented May 2, 2025

the issue above is not reproducible in MSYS2 CI by the way. probably something related with mixed host and target (we usually do host == target build)

@justsmth justsmth force-pushed the pc-windows-gnullvm branch 2 times, most recently from f33a445 to 9434186 Compare May 2, 2025 14:16
@justsmth justsmth force-pushed the pc-windows-gnullvm branch from 9434186 to 0860f00 Compare May 7, 2025 18:44
@justsmth justsmth changed the title [DRAFT] Build/Test for x86_64-pc-windows-gnullvm Build/Test for x86_64-pc-windows-gnullvm May 7, 2025
@justsmth justsmth marked this pull request as ready for review May 7, 2025 20:18
@justsmth justsmth requested a review from a team as a code owner May 7, 2025 20:18
@justsmth justsmth merged commit 2833d9b into aws:main May 8, 2025
279 of 287 checks passed
@justsmth justsmth deleted the pc-windows-gnullvm branch May 8, 2025 17:15
@ognevny
Copy link

ognevny commented May 8, 2025

thanks for all work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants