Verify contentinfo content is NULL is handled #1428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillChilds-Klein
previously approved these changes
Jan 31, 2024
Contributor
WillChilds-Klein
left a comment
WillChilds-Klein
left a comment
There was a problem hiding this comment.
LGTM, would be good to include details on how test files were generated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1428 +/- ##
==========================================
- Coverage 76.87% 76.86% -0.01%
==========================================
Files 425 425
Lines 71527 71527
==========================================
- Hits 54985 54979 -6
- Misses 16542 16548 +6 ☔ View full report in Codecov by Sentry. |
torben-hansen
force-pushed
the
contentinfo_null
branch
from
cc2c0af to
8242ae2
Compare
WillChilds-Klein
approved these changes
Feb 1, 2024
torben-hansen
requested review from
samuel40791765
and removed request for
andrewhop
samuel40791765
approved these changes
Feb 2, 2024
| // https://datatracker.ietf.org/doc/html/rfc7292#section-4.1; a sequence of | ||
| // ContentInfo's, where each Content field is Optional, again per RFC2315. We do | ||
| // not support this case either, the field cannot be absent. | ||
| // Below two test fixtures validates the above. See V1217527752. |
Contributor
There was a problem hiding this comment.
Would referencing CVE-2024-0727 from OpenSSL provide more context for external consumers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
V1217527752
Description of changes:
See code description and reference above.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.