-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenVPN error codes, SSL_get_peer_signature_* funcs, and first patch file #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1584 +/- ##
==========================================
- Coverage 78.16% 78.15% -0.01%
==========================================
Files 562 562
Lines 94683 94710 +27
Branches 13575 13579 +4
==========================================
+ Hits 74008 74022 +14
- Misses 20082 20093 +11
- Partials 593 595 +2 ☔ View full report in Codecov by Sentry. |
andrewhop
reviewed
May 10, 2024
smittals2
changed the title
WIP: OpenVPN Integration script, Patches, and Symbols
OpenVPN error codes, SSL_get_peer_signature_* funcs, and first patch file
Jun 4, 2024
geedo0
reviewed
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some style nits to fix.
geedo0
previously approved these changes
Jun 5, 2024
skmcgrail
requested changes
Jun 12, 2024
andrewhop
reviewed
Jun 14, 2024
skmcgrail
previously approved these changes
Jun 14, 2024
geedo0
approved these changes
Jun 17, 2024
skmcgrail
approved these changes
Jun 18, 2024
lilpoozie2005
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
CryptoAlg-2477
CryptoAlg-2478
Description of changes:
Call-outs:
The patch file is temporary and will likely change with future PRs
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.