Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure SSE2 is enabled when using optimized assembly for 32-bit x86 #1841

Merged
merged 5 commits into from
Sep 13, 2024
Merged

Ensure SSE2 is enabled when using optimized assembly for 32-bit x86 #1841

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
63e38c3
Always set -msse2 CFLAG when compiling for 32-bit x86
graebm Sep 9, 2024
e522724
Merge branch 'main' into x86-sse2-flag
graebm Sep 9, 2024
b8942d5
Include instructions for disabling SSE2
graebm Sep 10, 2024
966232e
Merge branch 'main' into x86-sse2-flag
graebm Sep 12, 2024
89dcbbf
Merge branch 'main' into x86-sse2-flag
graebm Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -824,6 +824,16 @@ else()
set(ARCH "generic")
endif()

# If target ARCH is 32-bit x86, ensure SSE2 is enabled since it's used by the optimized assembly.
# To build for targets that do not support SSE2, use the `OPENSSL_NO_ASM` flag.
if(ARCH STREQUAL "x86" AND NOT OPENSSL_NO_SSE2_FOR_TESTING)
graebm marked this conversation as resolved.
Show resolved Hide resolved
# Most compilers enable SSE2 in 32-bit x86 by default, but in some cases GCC and Clang don't.
# See: https://github.com/aws/aws-lc/commit/6fe8dcbe96e580ea85233fdb98a142e42951b70b
if(GCC OR CLANG)
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -msse2")
endif()
endif()

if(ENABLE_DATA_INDEPENDENT_TIMING_AARCH64)
add_definitions(-DMAKE_DIT_AVAILABLE)
endif()
Expand Down
Loading