Github action asserting license statement in PR description #1892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1892 +/- ##
==========================================
- Coverage 78.50% 78.47% -0.03%
==========================================
Files 585 585
Lines 99516 99516
Branches 14244 14243 -1
==========================================
- Hits 78122 78096 -26
- Misses 20759 20784 +25
- Partials 635 636 +1 ☔ View full report in Codecov by Sentry. |
skmcgrail
approved these changes
Oct 1, 2024
andrewhop
reviewed
Oct 1, 2024
Comment on lines
+56
to
+64
| # Normalize line endings (convert CRLF to LF) | ||
| PR_DESCRIPTION=$(echo "${PR_DESCRIPTION}" | tr -d '\r') | ||
|
|
||
| # Escape quotes in PR description | ||
| PR_DESCRIPTION=$(echo "${PR_DESCRIPTION}" | sed 's/"/\\"/g; s/'"'"'/\\'"'"'/g') | ||
|
|
||
| # Remove all spaces and tabs | ||
| PR_DESCRIPTION=$(echo "${PR_DESCRIPTION}" | tr -d ' \t') | ||
| LICENSE_STATEMENT=$(echo "${LICENSE_STATEMENT}" | tr -d ' \t') |
There was a problem hiding this comment.
Just curious, what is this needed for? The license statement is a single sentence so there should be no new lines, and a space is a space and should match right?
There was a problem hiding this comment.
I'm not sure. If I did:
- pushing PR with correct statement in the PR description
- modified PR statement to incorrect and then re-ran the job.
- modified PR statement back to correct and then re-ran the job.
(1) and (2) would return as expected i.e. former succeeded, the latter failed. But (3) would not return as expected, it would fail. Removing spaces etc. seems to have removed something that got encoded unexpected(?)
andrewhop
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Related to P151534254
Description of changes:
Simple action that asserts whether the license statement
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.exists in the PR description.I tested this by:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.