Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ML-KEM memory safety #2263

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

ML-KEM memory safety #2263

wants to merge 4 commits into from

Conversation

m271828
Copy link

@m271828 m271828 commented Mar 11, 2025

Description of changes:
WIP

Adds length parameters to ML KEM module to ensure allocated memory for keys can contain generated keys.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 89.09091% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.03%. Comparing base (8d77e4c) to head (bde3e83).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crypto/fipsmodule/ml_kem/ml_kem.c 80.64% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2263      +/-   ##
==========================================
- Coverage   79.04%   79.03%   -0.01%     
==========================================
  Files         612      612              
  Lines      106588   106632      +44     
  Branches    15083    15094      +11     
==========================================
+ Hits        84252    84279      +27     
- Misses      21684    21699      +15     
- Partials      652      654       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants