Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s2n-bignum build should use boringssl_prefix_symbols_asm.h #2265

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

justsmth
Copy link
Contributor

Related:

Description of changes:

MacOS assembly required the use of boringssl_prefix_symbols_asm.h

Call-outs:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner March 12, 2025 16:45
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.03%. Comparing base (aa43a85) to head (487b2b4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2265   +/-   ##
=======================================
  Coverage   79.02%   79.03%           
=======================================
  Files         612      612           
  Lines      106588   106588           
  Branches    15082    15084    +2     
=======================================
+ Hits        84232    84241    +9     
+ Misses      21703    21693   -10     
- Partials      653      654    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

torben-hansen
torben-hansen previously approved these changes Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants