Make AWS_LC_fips_failure_callback optional in builds with AWSLC_FIPS_FAILURE_CALLBACK #2266
+98
−55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This makes the FIPS callback optional when AWS-LC is built with AWSLC_FIPS_FAILURE_CALLBACK which turns it on. Previously if AWS-LC was built with AWSLC_FIPS_FAILURE_CALLBACK then any application that might link with AWS-LC would need to define the callback or AWS-LC would abort. Turns out that's hard to ensure, this change goes back to the old behavior:
Call-outs:
I had to remove
EXPECT_TRUE(EVP_PKEY_keygen(ed_ctx.get(), &ed_key));
because that keygen call should only happen after the check for the environment variable and now we're testing both paths.Testing:
I created a new test target that partially replicates our internal FIPS callback build.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.