-
Notifications
You must be signed in to change notification settings - Fork 133
Implement pkcs8 cli #2342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kingstjo
wants to merge
63
commits into
aws:main
Choose a base branch
from
kingstjo:implement-pkcs8-cli
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,023
−14
Open
Implement pkcs8 cli #2342
Changes from all commits
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
47a16a8
Implement PKCS8 CLI command for AWS-LC
8705147
Fix build errors in pkcs8 CLI implementation
9d01ae4
Fix unused variable warning in pkcs8 implementation
462bd64
Fix password path handling in pkcs8 tests
84091f2
Use default PKCS#5v2 encryption algorithm
ad85e58
Fix PRF handling and key type support in pkcs8 CLI tool
969665d
Merge branch 'aws:main' into implement-pkcs8-cli
kingstjo fe370f1
fix comment styling
6ae84e6
Merge branch 'main' into implement-pkcs8-cli
kingstjo caa1d64
Update v2prf implementation to only accept hmacWithSHA1 in pkcs8.cc
bb6552f
feat(pkcs8): improve memory safety with smart pointers
562482a
Fix pkcs8.cc OpenSSL 1.1.1 compatibility for -v2 option default value
1f8f0b9
Improve PKCS8 comparison tests by adding cross-compatibility validation
eb62ec0
added trim for formatting
0299545
-v2 -v2prf are default options with -topk8 and -passin when not provi…
2b752e2
fixing pass prompt
32cbdf2
Fix decryption of PKCS#8 encrypted keys from OpenSSL 1.1.1
bf0524b
temporary decryption debugging
9dc4cb8
temp debug fixes
0f8f4db
detailed decryption debugging
4a26183
Add enhanced PBES2 debugging output for PKCS#8 decryption issues
9fb8f3f
Enhance PKCS8 tool for OpenSSL compatibility
kingstjo f0d230d
fixed missing newline char EOF
kingstjo 2278744
tool-openssl: Enhance pkcs8 implementation with format options and pr…
kingstjo 76a81f8
tool-openssl: Add DER format support to PKCS8 implementation
kingstjo 6a40860
Fix pkcs8_test.cc build error by checking fgets() return value
kingstjo af5a7fd
Enhanced PKCS8 tool security improvements
kingstjo ae79ab1
Remove unused OpenSSLFree and OpenSSLPointer from internal.h
kingstjo 4c576e6
Implement BIO security improvements for PKCS8 tool
kingstjo 6375312
Refactor pkcs8.cc to reduce redundancy with internal.h
kingstjo 3d11475
Improve PKCS8 CLI code quality and robustness
kingstjo f245993
Improve PKCS8 CLI password handling
kingstjo 7866158
Simplify PKCS8 CLI code structure while preserving security
kingstjo 5188f8f
Improve comment style in PKCS8 CLI implementation
kingstjo 341acbb
Replace ScopedBIO wrapper class with direct bssl::UniquePtr<BIO> mana…
kingstjo 51ba849
refactor(tool-openssl): Fix pkcs8 tool argument parsing
kingstjo 5d86030
refactor: Move PKCS8-specific functions from internal.h to pkcs8.cc
kingstjo 19b89ca
Consolidate duplicate functions between RSA and PKCS8 tests
kingstjo 8e5e8da
Further consolidate code by removing remaining redundancies:
kingstjo 61fa106
Update namespacing for PEM markers with more descriptive names:
kingstjo d6a5024
Consolidate error handling in pkcs8.cc
kingstjo 36750d2
Fix format string vulnerability in pkcs8.cc by adding proper error ha…
kingstjo aff2e2d
Optimize pkcs8.cc: Add format validation helper and refactor topk8 pr…
kingstjo e7fd8d9
Enhance PKCS8 error handling with X-Macro pattern
kingstjo 77f7580
Improve PKCS8 error handling by removing unused error codes
kingstjo c86b620
Simplify pkcs8.cc implementation while preserving security features
kingstjo 205258b
Refactor pkcs8.cc to use library functions from pkcs8.h and pem.h
kingstjo edeac61
move struct into single point of usage
kingstjo 92b4fc1
Improve pkcs8.cc validate_bio_size() function for better security and…
kingstjo 224293a
Optimize password handling in pkcs8.cc by modifying in place instead …
kingstjo fd571d6
Merge branch 'main' into implement-pkcs8-cli
kingstjo 6f200ed
fix(tests): Fix segmentation fault in PKCS8ToolEnvVarPasswordTest
kingstjo d064725
add brace surrounding execution code for conditional statements
kingstjo 5b67fd6
Refactor pkcs8.cc to use consolidated error handling with goto err
kingstjo ae99941
pkcs8: Respect password args when -nocrypt is used
kingstjo 2bb453e
add TODO for password prompt implementation for OpenSSL 1.1.1 parity
kingstjo 491f94c
fix comments
kingstjo ed586cc
comments with file save
kingstjo 1e0ebcf
refactor(tool-openssl): consolidate rsa_pkcs8_shared into test_util.h
kingstjo 6dce6ff
revert over engineered encapsulation of rsa_test + pkcs8_test
kingstjo b011f6a
Move PKCS8-specific utilities from test_util.h to pkcs8_test.cc
kingstjo 4489b3c
Initialize variables in pkcs8.cc and pkcs8_test.cc to avoid undefined…
kingstjo 0a182c8
Replace goto err pattern with RAII using SensitiveString class in pkc…
kingstjo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.