[SCRUTINICE] Fix unchecked return value #2773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justsmth
previously approved these changes
Oct 28, 2025
justsmth
reviewed
Oct 28, 2025
Contributor
justsmth
left a comment
justsmth
left a comment
There was a problem hiding this comment.
A better resolution would be to return the failure to the caller.
nhatnghiho
force-pushed
the
scrutiny-fix
branch
from
ad15529 to
890c725
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2773 +/- ##
==========================================
+ Coverage 78.25% 78.43% +0.18%
==========================================
Files 683 683
Lines 117183 117185 +2
Branches 16474 16481 +7
==========================================
+ Hits 91698 91913 +215
+ Misses 24604 24388 -216
- Partials 881 884 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
approved these changes
Nov 13, 2025
justsmth
changed the title
torben-hansen
approved these changes
Nov 13, 2025
sgmenda-aws
approved these changes
Nov 13, 2025
ttungle96
pushed a commit
to ttungle96/aws-lc
that referenced
this pull request
Nov 14, 2025
### Issues: Resolves P321757685 ### Description of changes: Fix a scrutiny warning with an unchecked return value By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license. Co-authored-by: Sanketh Menda <sgmenda@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves P321757685
Description of changes:
Fix a scrutiny warning with an unchecked return value
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.