generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 154
Add encap/decapKeyCheck support in ACVP #2872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+159
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skmcgrail
previously approved these changes
Dec 2, 2025
torben-hansen
previously approved these changes
Dec 2, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2872 +/- ##
==========================================
- Coverage 78.24% 78.23% -0.01%
==========================================
Files 683 683
Lines 117388 117412 +24
Branches 16497 16503 +6
==========================================
+ Hits 91853 91863 +10
- Misses 24649 24663 +14
Partials 886 886 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dkostic
previously approved these changes
Dec 2, 2025
ff4fa4f
4bf6877 to
ff4fa4f
Compare
torben-hansen
approved these changes
Dec 2, 2025
dkostic
approved these changes
Dec 2, 2025
samuel40791765
added a commit
to samuel40791765/aws-lc
that referenced
this pull request
Dec 2, 2025
ACVP has support for a new test vectors that test against the encapsulation/decapsulation key checks defined in FIPS 203. > Adds "encapsulationKeyCheck" and "decapsulationKeyCheck" as functions for ML-KEM Encap/Decap FIPS203 to exercise an implementation's capability to perform the Encapsulation Key Check in FIPS 203 Section 7.2 and the Decapsulation Key Check in FIPS 203 Section 7.3. These tests are only included if the appropriate function is present in the registration. They operate by providing a valid or invalid key and expecting the IUT to return a true for a valid key or false for an invalid key. * https://github.com/usnistgov/ACVP-Server/releases This add support in ACVP to run against the relevant `crypto_kem_check_pk` and `crypto_kem_check_sk` functions that do the checks for us. Also added the new `encapsulationKeyCheck` and `decapsulationKeyCheck` test vectors in `ML-KEM.bz2`. ### Call-outs: N/A ### Testing: new `encapsulationKeyCheck` and `decapsulationKeyCheck` test vectors in `ML-KEM.bz2` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license. (cherry picked from commit 0336dd7)
samuel40791765
added a commit
to samuel40791765/aws-lc
that referenced
this pull request
Dec 2, 2025
ACVP has support for a new test vectors that test against the encapsulation/decapsulation key checks defined in FIPS 203. > Adds "encapsulationKeyCheck" and "decapsulationKeyCheck" as functions for ML-KEM Encap/Decap FIPS203 to exercise an implementation's capability to perform the Encapsulation Key Check in FIPS 203 Section 7.2 and the Decapsulation Key Check in FIPS 203 Section 7.3. These tests are only included if the appropriate function is present in the registration. They operate by providing a valid or invalid key and expecting the IUT to return a true for a valid key or false for an invalid key. * https://github.com/usnistgov/ACVP-Server/releases This add support in ACVP to run against the relevant `crypto_kem_check_pk` and `crypto_kem_check_sk` functions that do the checks for us. Also added the new `encapsulationKeyCheck` and `decapsulationKeyCheck` test vectors in `ML-KEM.bz2`. N/A new `encapsulationKeyCheck` and `decapsulationKeyCheck` test vectors in `ML-KEM.bz2` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
ACVP has support for a new test vectors that test against the encapsulation/decapsulation key checks defined in FIPS 203.
This add support in ACVP to run against the relevant
crypto_kem_check_pkandcrypto_kem_check_skfunctions that do the checks for us. Also added the newencapsulationKeyCheckanddecapsulationKeyChecktest vectors inML-KEM.bz2.Call-outs:
N/A
Testing:
new
encapsulationKeyCheckanddecapsulationKeyChecktest vectors inML-KEM.bz2By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.