Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for external id for role-based authentication #109

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

siuryan
Copy link
Contributor

@siuryan siuryan commented Feb 24, 2023

Issue #, if available: #108

Description of changes: This adds support for specifying an external id when authenticating to the MSK cluster using a role ARN. Previously, if an external id was specified on the role's trust relationship, authenticating to the cluster would throw an exception.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@siuryan siuryan changed the title Add support for external id in auth Add support for external id in role-based authentication Feb 24, 2023
@siuryan siuryan changed the title Add support for external id in role-based authentication Add support for external id for role-based authentication Feb 24, 2023
Copy link
Contributor

@sayantacC sayantacC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the PR.

@sayantacC sayantacC merged commit 648003c into aws:main Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants