Update aws sdk #22
Merged
Update aws sdk #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fabian Martinez <46371672+famarting@users.noreply.github.com>
Signed-off-by: Fabian Martinez <46371672+famarting@users.noreply.github.com>
|
cc @agarwal1510 |
agarwal1510
reviewed
Nov 12, 2024
| @@ -16,7 +16,7 @@ import ( | |||
| "time" | |||
|
|
|||
| "github.com/aws/aws-sdk-go-v2/aws" | |||
| "github.com/aws/aws-sdk-go-v2/aws/signer/v4" | |||
| v4 "github.com/aws/aws-sdk-go-v2/aws/signer/v4" | |||
There was a problem hiding this comment.
Do we need this v4 here?
agarwal1510
approved these changes
Nov 20, 2024
|
@famarting Go tests are failing with error: |
Signed-off-by: Fabian Martinez <46371672+famarting@users.noreply.github.com>
|
can you trigger CI again @agarwal1510 |
|
Ping @agarwal1510 |
agarwal1510
approved these changes
Nov 24, 2024
Signed-off-by: Fabian Martinez <46371672+famarting@users.noreply.github.com>
|
@agarwal1510 can you trigger CI again? I had to update the supported go versions following https://github.com/aws/aws-sdk-go-v2/blob/main/.github/workflows/go.yml |
agarwal1510
reviewed
Nov 25, 2024
| @@ -16,7 +16,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| os: [ubuntu-latest, macos-latest, windows-latest] | |||
| go-version: [1.19, "1.20"] | |||
| go-version: ["1.21", "1.22", "1.23"] | |||
There was a problem hiding this comment.
We want to support Go 1.20 which is also supported by AWS SDK. Please change the min to 1.20 in the PR.
There was a problem hiding this comment.
Was looking at outdated documentation, the library supports 1.21 as the minimum version. Approved.
agarwal1510
approved these changes
Nov 25, 2024
|
Thank you |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16