Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug vesion unit tests steps in document #165

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

RoyZhang2022
Copy link
Contributor

@RoyZhang2022 RoyZhang2022 commented Nov 15, 2023

Jira Ticket

Review Status

  • This is ready for review
  • This is complete

Summary

Add debug vesion unit tests steps in document

Description

  • Add debug version unit tests steps
  • Unit tests could use AWS SDK dlls on Windows instead of static linking to AWS SDK libraries

Additional Reviewers

@@ -1,11 +1,25 @@
# Testing the AWS ODBC Driver for MySQL
## Unit Tests
1. Build driver binaries with `ENABLE_UNIT_TESTS` command set to `TRUE`:
1. Build driver binaries with `ENABLE_UNIT_TESTS` command set to `TRUE` under repository root:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"under repository root"? Do you mean the command needs to be run from the repo root?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we instead specify that before the commands on lines 10,20,25,30?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I think this will also be updated later to use a build script instead of command here to make it simple.

  * Add debug version unit tests steps
  * Unit tests could use AWS SDK dlls on Windows instead of
    static linking to AWS SDK libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants