-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove strict response verification and update dependencies #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petreeftime
force-pushed
the
main
branch
2 times, most recently
from
April 15, 2022 14:15
8cf4ef5
to
caf990c
Compare
alcioa
reviewed
Apr 19, 2022
alcioa
reviewed
Apr 19, 2022
OUTPUT_STRIP_TRAILING_WHITESPACE | ||
OUTPUT_VARIABLE VERSION) | ||
if ("${VERSION}" STREQUAL "") | ||
set(VERSION "v0.2.0-unknown") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next bump to v0.2.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do a version ID bumps after this gets merged and properly tested.
alcioa
previously approved these changes
Apr 19, 2022
Signed-off-by: Petre Eftime <epetre@amazon.com>
Signed-off-by: Petre Eftime <epetre@amazon.com> fix args parsing Signed-off-by: Petre Eftime <epetre@amazon.com>
Signed-off-by: Petre Eftime <epetre@amazon.com>
Signed-off-by: Petre Eftime <epetre@amazon.com>
Useful for testing against custom endpoints. Signed-off-by: Petre Eftime <epetre@amazon.com>
Signed-off-by: Petre Eftime <epetre@amazon.com>
Signed-off-by: Petre Eftime <epetre@amazon.com>
ghost
approved these changes
Apr 19, 2022
alcioa
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.