Skip to content

Enable livenessProbe in queue processor mode by default #520

@gabegorelick

Description

@gabegorelick

Describe the feature
#389 added a livenessProbe, but it's off by default. If using helm it can be enabled by setting enableProbesServer. If using one of the queue processor release artifacts that are generated from the helm chart, e.g. all-resources-queue-processor.yaml, then the livenessProbe won't be enabled. This is despite the fact that #333 characterized the livenessProbe as "a reasonable thing to add to aws-node-termination-handler especially when operating in queue-processor mode."

Is the feature request related to a problem?
livenessProbe helps detect if NTH is unhealthy. It's also required by a lot of automated scanners, linters, and policy engines.

Describe alternatives you've considered
Use the helm chart and set enableProbesServer or patch the release artifact yourself.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions