Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation in using Queue Processor with Karpenter #547

Closed
aldredb opened this issue Dec 14, 2021 · 15 comments
Closed

Add documentation in using Queue Processor with Karpenter #547

aldredb opened this issue Dec 14, 2021 · 15 comments
Labels

Comments

@aldredb
Copy link

aldredb commented Dec 14, 2021

Describe the feature
I'm using NTH with Karpenter. Since Karpenter does not use ASG, I require documentation in using Queue Processor with Karpenter e.g. using ASSUME_ASG_TAG_PROPAGATION

Is the feature request related to a problem?
N/A

Describe alternatives you've considered
N/A

@stevehipwell
Copy link
Contributor

I thought Karpenter dealt with it's own node lifecycle? @ellistarn @bwagner5 should be able to answer this definitively.

@aldredb
Copy link
Author

aldredb commented Dec 15, 2021

@stevehipwell As of now, Karpenter need to rely on NTH for spot interruption handling

@stevehipwell
Copy link
Contributor

@aldredb I thought that was a pre GA priority but you're right (aws/karpenter-provider-aws#702).

@bwagner5
Copy link
Contributor

Karpenter does not handle Spot ITNs with the full 2 minutes to drain workloads. It also doesn't handle Rebalance Recommendations which would give workloads longer to drain. Karpenter does cordon and drain nodes when an operator deletes a nodes w/ kubectl or Karpenter itself terminates a node due to no pods running on it. But Karpenter will not react to AWS terminating a node like in the case of Spot ITNs.

We are still looking to add spot handling natively to Karpenter, but NTH will need to be installed for now.

@bwagner5
Copy link
Contributor

I think we should add the docs to Karpenter instead of NTH since Karpenter has a nicer docs site. Once we get it into Karpenter, we can link it off of NTH's docs.

@bwagner5 bwagner5 added the docs label Dec 15, 2021
@sidewinder12s
Copy link

sidewinder12s commented Dec 17, 2021

I've got a custom autoscaler as well that does not use ASGs, this would be useful to document since it should be similar requirements.

@olemarkus
Copy link

I am curious why you wouldn't want NTH to deal with spot terminations also together with karpenter? Karpenter's area of responsibility within a cluster is already pretty huge for a controller and I think NTH does its job pretty well.

@olemarkus
Copy link

Most clusters will be mixed Karpenter and CAS-based anyway given that most people cannot run Karpenter on the Control Plane, so NTH is most likely needed anyway.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want this issue to never become stale, please ask a maintainer to apply the "stalebot-ignore" label.

@github-actions github-actions bot added the stale Issues / PRs with no activity label Jan 25, 2022
@github-actions
Copy link

This issue was closed because it has become stale with no activity.

@tamirhad
Copy link

When using NTH with SQS queue, ENABLE_SPOT_INTERRUPTION_DRAINING is always false when deploying with helm.
Is it expected? It's not something we need to be true?

@stevehipwell
Copy link
Contributor

@tamirhad this is expected as I replied on the other thread that you asked this question on. Despite some AWS docs referring to this value when also specifying queue mode, ENABLE_SPOT_INTERRUPTION_DRAINING is only used for IMDS mode.

@universam1
Copy link
Contributor

can we reopen this issue please? I actually have issues to properly configure NTH for Karpenter nodes #654

@aavileli
Copy link

please update karpentar documentation that users need to use NTH(with Queue Processor) for aws api termination for spot and on-demnad instances

@snay2
Copy link
Contributor

snay2 commented Jul 20, 2022

As @bwagner5 mentioned, this would fit better in the Karpenter documentation.

I have opened an issue on the Karpenter repo and recommend that the discussion continue there: aws/karpenter-provider-aws#2159

@snay2 snay2 closed this as completed Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants