Skip to content

Conversation

@gaffneyd4
Copy link
Contributor

Description of changes:

If webhookTemplateConfigMapName and webhookTemplateConfigMapKey are not set in the values.yaml file, we end up with a deployment.yaml file that has key volumes with a nil value. This causes other tools like kustomize to throw warnings:

2022/01/03 18:04:29 nil value at `volumes.configMap.name` ignored in mutation attempt
2022/01/03 18:04:29 nil value at `volumes.projected.sources.configMap.name` ignored in mutation attempt
2022/01/03 18:04:29 nil value at `volumes.secret.secretName` ignored in mutation attempt
2022/01/03 18:04:29 nil value at `volumes.projected.sources.secret.name` ignored in mutation attempt
2022/01/03 18:04:29 nil value at `volumes.persistentVolumeClaim.claimName` ignored in mutation attempt

This PR wraps the volumes key in the conditional as well so that if it is not being used it doesn't cause these warnings.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gaffneyd4 gaffneyd4 requested a review from a team as a code owner January 3, 2022 23:40
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants