use gha cache #567
Merged
use gha cache #567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snay2
reviewed
Feb 1, 2022
Contributor
snay2
left a comment
snay2
left a comment
There was a problem hiding this comment.
What is the intention of this change? Should it improve build times? Reduce build failures?
Does it come with any additional costs (e.g., GHA capacity usage)?
snay2
approved these changes
Feb 1, 2022
Contributor
snay2
left a comment
snay2
left a comment
There was a problem hiding this comment.
Discussed during the SIG meeting. Risks are low. Build times improved dramatically when they did this on Karpenter, so we're going to merge it and see what benefit we get.
Contributor
Author
|
I think I remember why I haven't done this before... because we're building NTH in containers so we'd need to do some storage mapping to get this to work properly.... I'm going to merge since this will still be necessary and doesn't hurt things currently, but I guess there's some more work to do here :) |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.