Skip to content

Support ASG-to-SQS Lifecycle Termination events #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 7, 2022
Merged

Support ASG-to-SQS Lifecycle Termination events #568

merged 5 commits into from
Feb 7, 2022

Conversation

@AustinSiu
Copy link
Contributor

Issue #, if available: #356

Description of changes:

  • Check SQS message for a Lifecycle termination event sent directly from ASG to SQS (different schema than from EventBridge to SQS)
  • Update README with new/updated instructions to set up Lifecycle hook and IAM access roles

These changes are meant to help support only Lifecycle termination events from ASG sent to SQS.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AustinSiu AustinSiu requested a review from a team as a code owner February 1, 2022 06:48
@snay2 snay2 mentioned this pull request Feb 1, 2022
Closed
bwagner5
bwagner5 requested changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! just a few comments

brycahta
brycahta suggested changes Feb 1, 2022
View reviewed changes
@AustinSiu AustinSiu changed the title Feature asg sqs direct Support ASG-to-SQS Lifecycle Termination events Feb 2, 2022
brycahta
brycahta previously approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@brycahta brycahta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm looks clean 👍

snay2
snay2 reviewed Feb 4, 2022
View reviewed changes
bwagner5
bwagner5 previously approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AustinSiu AustinSiu dismissed stale reviews from bwagner5 and brycahta via fc3b18f February 7, 2022 22:05
brycahta
brycahta approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@brycahta brycahta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@snay2
Copy link
Contributor

snay2 commented Feb 7, 2022

/lgtm

@AustinSiu AustinSiu merged commit 33c6238 into aws:main Feb 7, 2022
@ec2-bot ec2-bot mentioned this pull request Feb 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bwagner5 bwagner5 bwagner5 left review comments

+2 more reviewers

@snay2 snay2 snay2 left review comments

@brycahta brycahta brycahta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AustinSiu @snay2 @bwagner5 @brycahta