ARM compute images on batch #1830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The process for building the container used in the Batch cluster compute environments assumed an x86_64 architecture: * architecture-specific openmpi binaries and libraries were installed * x86_64 CodeBuild environments and images were used This commit: * drops the architecture specifier when installing openmpi, allowing the package manager to figure out which ones to install * configures the CodeBuild environment dynamically by passing the Architecture parameter from the main CFN stack into the Batch substack * installs hostname, which is used by an integration test The values used for the ComputeType and Type parameters of the CodeBuild resource when building for ARM were chosen based on the information at this link: https://docs.aws.amazon.com/codebuild/latest/userguide/build-env-ref-compute-types.html Still TODO: * there are some regional restrictions for the environments needed to build for ARM, which probably means that we can only support ARM Batch clusters in those regions. Add validators for those cases.
tilne
force-pushed
the
arm-compute-images-on-batch
branch
from
a77d917
to
f894e4e
Compare
Codecov Report
@@ Coverage Diff @@
## wip/arm-support-feature-branch #1830 +/- ##
===============================================================
Coverage 54.67% 54.67%
===============================================================
Files 28 28
Lines 4499 4499
===============================================================
Hits 2460 2460
Misses 2039 2039 Continue to review full report at Codecov.
|
demartinofra
approved these changes
Jun 12, 2020
tilne
force-pushed
the
arm-compute-images-on-batch
branch
from
f894e4e
to
e289b0d
Compare
|
Clicking through to the travis status link shows that all tests have passed. Because of this and the fact that this is being merged into a feature branch and not develop I'm going to go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.