Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore instance type sanity check using cluster ami #2487

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

ddeidda
Copy link
Contributor

@ddeidda ddeidda commented Feb 26, 2021

This commit restores the fix for instance type sanity checks using the actual cluster AMI, including new logic to handle the case where the AMIs are still under development.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ddeidda ddeidda added the skip-changelog-update Disables the check that enforces changelog updates in PRs label Feb 26, 2021
@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #2487 (575eedd) into develop (b3dd0ea) will increase coverage by 0.18%.
The diff coverage is 93.75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2487      +/-   ##
===========================================
+ Coverage    61.85%   62.03%   +0.18%     
===========================================
  Files           40       40              
  Lines         6189     6214      +25     
===========================================
+ Hits          3828     3855      +27     
+ Misses        2361     2359       -2     
Impacted Files Coverage Δ
cli/src/pcluster/models/hit/hit_cluster_model.py 22.58% <0.00%> (ø)
cli/src/pcluster/models/sit/sit_cluster_model.py 19.35% <0.00%> (ø)
cli/src/pcluster/cluster_model.py 61.81% <100.00%> (+12.40%) ⬆️
cli/src/pcluster/utils.py 67.63% <0.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3dd0ea...575eedd. Read the comment docs.

demartinofra
demartinofra previously approved these changes Feb 26, 2021
This commit restores the fix for instance type sanity checks using the actual cluster AMI, including new logic to handle the case where the AMIs are still under development.

Signed-off-by: ddeidda <ddeidda@amazon.com>
@ddeidda ddeidda merged commit 9eabda4 into aws:develop Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants