Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change packing to use npm pack to included nested node_modules #785

Merged
merged 1 commit into from
May 23, 2024

Conversation

agdimech
Copy link
Contributor

@agdimech agdimech commented May 23, 2024

Nested node_modules were being emitted from the tgz that was being published to npm. This should hopefully resolve the issue by performing the following:

  • Only install prod dependencies when running pnpm deploy
  • Hoist installed dependencies when running pnpm deploy
  • Use standard npm pack oppose to pnpm pack.
  • Added verbose logging for the packing command to verify local vs remote manifest matching.

Fixes #755

@agdimech agdimech merged commit 58497d9 into mainline May 23, 2024
4 checks passed
@agdimech agdimech deleted the fix/755 branch May 23, 2024 22:56
agdimech added a commit that referenced this pull request May 23, 2024
agdimech added a commit that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] npm ci fails after installing @aws/pdk
1 participant