Improve Dirty Tracking of Mutable Collection Types #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds mutation tracking of attributes in `Aws::Record` models. This is turned on by default for the collection types: `:list_attr`, `:map_attr`, `:string_set_attr`, and `:numeric_set_attr`. But can be enabled/disabled for individual attributes, and disabled if desired at the model level.
An if/else sequence was not an appropriate choice, logically. This change creates an "or" check on both the dirty data hash and on the mutation tracking system.
|
Some offline review comments about the private API side of how the duplicates are stored. Merging to move on to the next feature/refactors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds mutation tracking of attributes in
Aws::Recordmodels. This is turned on by default for the collection types::list_attr,:map_attr,:string_set_attr, and:numeric_set_attr. But can be enabled/disabled for individual attributes, and disabled if desired at the model level.