Persistence Refactors for Nil Handling #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change covers a few different areas related to our persistence logic: * All calls to `Aws::DynamoDB::Client#update_item` now use update expressions exclusively. * `nil` values will not be persisted in any case unless `:persist_nil` is set for the attribute(s) in question. There are also collection-specific parameters to persist nil as empty collections in some cases, which are now honored. * Update calls will now use the `REMOVE` expression when the value is `nil` and `:persist_nil` is `false` for the attribute.
Need a reliable way to prove the attribute was truly deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change covers a few different areas related to our persistence
logic:
Aws::DynamoDB::Client#update_itemnow use updateexpressions exclusively.
nilvalues will not be persisted in any case unless:persist_nilis set for the attribute(s) in question. There are also
collection-specific parameters to persist nil as empty collections in
some cases, which are now honored.
REMOVEexpression when the value isniland:persist_nilisfalsefor the attribute.