Refactor Attribute Tracking Code #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces the `ModelAttributes` and `ItemData` classes for tracking of model level attribute information, and item level attribute data, respectively. These changes don't impact the user-facing API, but should help improve understandability and maintainability of the codebase. There is one change to the external API, and that is that mutation tracking is now on or off at the full table level, and cannot be toggled on a per-attribute level.
* Abstracts key attribute handling into the `Aws::Record::KeyAttributes` internal class with composition. * Makes the `#keys` and `#clean!` methods API private (do not use these directly in your code). * Additional smaller refactors of redundant code.
Fixes two code smells.
The `coveralls` gem depends on the `tins` gem, which now requires Ruby version 2.0 or greater. To keep Travis tests working, remove this as a required dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces the
ModelAttributesandItemDataclasses fortracking of model level attribute information, and item level attribute
data, respectively. These changes don't impact the user-facing API, but
should help improve understandability and maintainability of the
codebase.
There is one change to the external API, and that is that mutation
tracking is now on or off at the full table level, and cannot be toggled
on a per-attribute level.