Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'NameError: uninitialized constant PKG_NAME' #32

Merged
merged 1 commit into from
Aug 16, 2016
Merged

Fix 'NameError: uninitialized constant PKG_NAME' #32

merged 1 commit into from
Aug 16, 2016

Conversation

adomokos
Copy link
Contributor

When I ran bundle exec rake -T, I received the following error:

[DEPRECATION] `last_comment` is deprecated.  Please use `last_description` instead.
rake aborted!
NameError: uninitialized constant PKG_NAME
vendor/bundle/ruby/2.3.0/gems/addressable-2.4.0/tasks/gem.rake:5:in `block (2 levels) in <top (required)>'
vendor/bundle/ruby/2.3.0/gems/addressable-2.4.0/tasks/gem.rake:4:in `new'
vendor/bundle/ruby/2.3.0/gems/addressable-2.4.0/tasks/gem.rake:4:in `block in <top (required)>'
vendor/bundle/ruby/2.3.0/gems/addressable-2.4.0/tasks/gem.rake:3:in `<top (required)>'
/Users/adomokos/Programming/Ruby/oss/aws-sdk-ruby-record/Rakefile:23:in `load'
/Users/adomokos/Programming/Ruby/oss/aws-sdk-ruby-record/Rakefile:23:in `block in <top (required)>'
/Users/adomokos/Programming/Ruby/oss/aws-sdk-ruby-record/Rakefile:22:in `each'
/Users/adomokos/Programming/Ruby/oss/aws-sdk-ruby-record/Rakefile:22:in `<top (required)>'
/Users/adomokos/Programming/Ruby/oss/aws-sdk-ruby-record/vendor/bundle/ruby/2.3.0/gems/rake-11.2.2/exe/rake:27:in `<top (required)>'
(See full trace by running task with --trace)

I believe the problem is loading more files than you have to for rake.

With the change, listing of the tasks work properly:

[DEPRECATION] `last_comment` is deprecated.  Please use `last_description` instead.
rake coveralls:push    # Push latest coverage results to Coveralls.io
rake docs              # Generate doc files
rake docs:zip          # Generates docs.zip
rake gems:build        # Builds the aws-record gem
rake release           # Public release, `VERSION=x.y.z rake release`
rake test              # Runs unit and integration tests
rake test:integration  # Runs integration tests / aws-record integration tests
rake test:unit         # Runs unit tests / aws-record unit tests

OS: OS X 10.11.6
Ruby version: ruby 2.3.0p0 (2015-12-25 revision 53290) [x86_64-darwin15]

@coveralls
Copy link

coveralls commented Aug 16, 2016

Coverage Status

Coverage remained the same at 97.638% when pulling a091bae on adomokos:ad-fix-rake-dash-t into 6343aca on aws:master.

@awood45
Copy link
Member

awood45 commented Aug 16, 2016

Thanks!

@awood45 awood45 merged commit 7868f8b into aws:master Aug 16, 2016
@adomokos adomokos deleted the ad-fix-rake-dash-t branch August 16, 2016 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants