-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aws::Record::TableConfig #52
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP at this stage, but basic minimal configuration and migration from a blank slate is supported.
3 similar comments
Checks values in TableConfig, WIP to support model comparison.
1 similar comment
Still need to address partial migrations, error handling, and global secondary index support.
Currently, would raise the DynamoDB error, which seems unncessary in this case.
Recognizes when a table already exists in Amazon DynamoDB, and will attempt to perform an `#update_table` call for the config delta.
2 similar comments
Validating required configuration and adding tests
The `#compatible?` and `#exact_match?` methods work with global secondary indexes. Next steps are to support migrations with GSIs.
5 similar comments
WIP, current only adds to create_table
`Aws::Record::TableConfig#migrate!` can now handle table updates involving global secondary indexes.
Adds method and class documentation for `Aws::Record::TableConfig`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic table configuration and migration support for aws-record.