Add Support for On-Demand Capacity to TableConfig #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remaining: Some global secondary index-based migrations are untested. These should be tested and handled properly before merging.
Brings support for on-demand capacity to TableConfig.
There is no such thing as a free lunch.
cjyclaire
approved these changes
Dec 5, 2018
| @@ -59,7 +70,9 @@ module Record | |||
| # :title, | |||
| # hash_key: :forum_uuid, | |||
| # range_key: :post_title, | |||
| # projection_type: "ALL" | |||
There was a problem hiding this comment.
I don't see any related code changes with this doc update (besides tests), so I'm assuming this is for updating docs to reflect current behavior?
There was a problem hiding this comment.
Correct, that's actually a doc bug.
The DynamoDB service raises a ValidationError per the integration tests in cases where you provide a `:billing_mode` option when no change occurred. This change ensures that does not happen, and updates unit tests appropriately.
cjyclaire
approved these changes
Dec 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the "PAY_PER_REQUEST" billing mode, and has integration tests as well as unit tests for the different related scenarios.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.