Add support for on-demand billing to table migrations. #94
Conversation
2 similar comments
|
I discovered this issue recently. This pull request has had its second birthday. Are there any plans for it? |
|
cc/ @alextwoods |
|
Thanks for the ping on this! Reviewing now.... |
| test_gsi: { | ||
| read_capacity_units: 1, | ||
| write_capacity_units: 1 | ||
| context 'when the table is not configured ot use on-demand billing' do |
| ) | ||
| end | ||
| gsis_with_throughput = _add_throughout_to_gsis(gsis, gsit) | ||
| create_opts[:global_secondary_indexes] = gsis_with_throughput | ||
| gsis_opts = if opts.key?(:billing_mode) |
There was a problem hiding this comment.
should this check billing_mode equal to PAY_PER_REQUEST?
alboyadjian
force-pushed
the
on-demand-billing-migration
branch
2 times, most recently
from
6acfc31 to
67800dc
Compare
Accepts :billing_mode option, with values of PAY_PER_REQUEST or PROVISIONED. If :provisioned_throughput is set, :billing_mode must either not be set or set to PROVISIONED. If :provisioned_throughput is not set, :billing_mode must be set and must be PAY_PER_REQUEST. Setting :billing_mode to PAY_PER_REQUEST is invalid if :provisioned_throughput is specified. Global secondary index througput config is not needed if on-demand billing is set for the table.
alboyadjian
force-pushed
the
on-demand-billing-migration
branch
from
67800dc to
82819d1
Compare
|
Looks good - thanks for submitting and apologies it took so long for us to get merged. I'll get a release with a new version out today. |
|
@alextwoods Thanks for merging this in! What needs to happen for tagging a new version release? Is there anything we can do to support that? |
|
Forgot to post here, but this change has been released with aws-record 2.6.0 that went out last week (May 13th). |
|
Yeah, I didn't see the release tagged here in the repository, although I see that the version was updated in the code. |
|
Was looking here: https://github.com/aws/aws-sdk-ruby-record/releases |
|
Oh - thanks for the callout - usually our release process updates those automatically, but I had some issues with the release scripts. I've manually created/tagged the 2.6.0 release. |
Accepts :billing_mode option, with values of PAY_PER_REQUEST or PROVISIONED.
If :provisioned_throughput is set, :billing_mode must either not be set or set to PROVISIONED.
If :provisioned_throughput is not set, :billing_mode must be set and must be PAY_PER_REQUEST.
Setting :billing_mode to PAY_PER_REQUEST is invalid if :provisioned_throughput is specified.
Global secondary index througput config is not needed if on-demand billing is set for the table.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.