Smart Query #98
Merged
Smart Query #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to flesh out unit tests, cover all the relevant options, and add documentation to the top-level methods.
Should be able to build any query/scan you reasonably need to, now.
A few edge cases around exceptions aren't covered yet, will get to that after documentation
Filled in documentation for the DSL methods as well as for the top level methods.
No symbolized arguments for me, this time.
1 similar comment
cjyclaire
approved these changes
Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes: Add the ability to build query and scan expressions in aws-record using a substitution expression. Includes integration and unit tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.