Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deadline): add usage-based licensing ports for new Cinema4d versions #1142

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

leongdl
Copy link
Contributor

@leongdl leongdl commented Nov 21, 2023

Problem:

  • It was reported by several customers newer versions of Cinema4d do not work with RFDK.
    UsageBasedLicensing.for_cinema_4d() is supposed to set up UBL for cinema4d, but it is missing some ports. Cinema4d switched to ports from 5057 and 7057 to 5058 and 7058 so RFDK no longer works without manual configs in newer versions like C4D 2023.

Solution:

  • Add the additional ports as required. To keep backwards compatibility, prior ports are kept.

Testing:

  • ./build.sh
  • yarn build+test
=============================== Coverage summary ===============================
Statements   : 97.93% ( 3316/3386 )
Branches     : 95.07% ( 1043/1097 )
Functions    : 96.98% ( 514/530 )
Lines        : 98.09% ( 3196/3258 )
================================================================================

Test Suites: 62 passed, 62 total
Tests:       1278 passed, 1278 total
Snapshots:   0 total
Time:        47.823 s, estimated 67 s

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@jusiskin jusiskin changed the title fix(aws-rfdk) Add additional ports for Cinema4d usage base license access. fix(deadline): add usage-based licensing ports for new Cinema4d versions Nov 21, 2023
@jusiskin jusiskin added the bug This issue is a bug. label Nov 21, 2023
@ddneilson ddneilson merged commit 213605d into aws:mainline Nov 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants