Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deadline): DocumentDB engine version support upgraded upto v5.0 #1155

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

sakshie95
Copy link
Contributor

@sakshie95 sakshie95 commented Dec 13, 2023

Problem
Only documentDB engine version 3.6 was supported before current Deadline release 10.3.1.3. With the MongoDB and DocumentDB version upgrades to 5.0 all versions (3.6, 4.0, 5.0) are supported with Deadline. We need to relax constraints on engine version 3.6 that exist in RFDK

Solution
Upgraded engine version support to all versions prefix with 3.6, 4.0 or 5.0 as per the compatibility now. Updated relevant documentation in the code as well. Removed a Unit Test case testing the engine version constraint to 3.6. Since there are no other versions of DocumentDB available we need not add this test case with a different parameter.

Testing

  1. yarn build:
aws-rfdk: =============================== Coverage summary ===============================
aws-rfdk: Statements   : 97.93% ( 3316/3386 )
aws-rfdk: Branches     : 95.08% ( 1045/1099 )
aws-rfdk: Functions    : 96.98% ( 514/530 )
aws-rfdk: Lines        : 98.09% ( 3196/3258 )
aws-rfdk: ================================================================================
aws-rfdk: Test Suites: 62 passed, 62 total
aws-rfdk: Tests:       1277 passed, 1277 total
aws-rfdk: Snapshots:   0 total
aws-rfdk: Time:        240.366 s
  1. Deployed the All-In-Infrastructure-SEP stack in my AWS account with default engine version set to 3.6, confirmed it spun up and tore down successfully.

  2. Manually updated the default version of DocDB to 5.0 and deployed the All-In-Infrastructure-SEP stack with the updated engine version to validate it works fine.

  3. Ran the integration tests using my AWS account as well. Validated that they run fine.

Test Suites: 1 passed, 1 total
Tests:       21 passed, 21 total
Snapshots:   0 total
Time:        35.8 s, estimated 44 s
Ran all test suites matching /deadline_01_repository.test/i.
Test results written to: .e2etemp/deadline_01_repository/test-report.json

@ddneilson
Copy link
Contributor

Aside, we should also add the ability for the user to select their DocumentDB engine version when using the defaults in the Repository construct.

Copy link
Contributor

@jericht jericht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Daniel's comments. Ready to approve once both of those are addressed.

@sakshie95
Copy link
Contributor Author

sakshie95 commented Dec 14, 2023

Aside, we should also add the ability for the user to select their DocumentDB engine version when using the defaults in the Repository construct.

Discussed this offline with @ddneilson. This is a feature that would need a data migration strategy for the customers to migrate their data from older version to a newer version which they can choose. Logged a backlog item for this

@sakshie95 sakshie95 closed this Dec 14, 2023
@ddneilson ddneilson reopened this Dec 14, 2023
@sakshie95
Copy link
Contributor Author

sakshie95 commented Dec 14, 2023

I agree with Daniel's comments. Ready to approve once both of those are addressed.

Addressed & resolved both comments!

@ddneilson ddneilson merged commit 7905f91 into aws:mainline Dec 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants