Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): deprecate NodeJS pre 18.* #1163

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

jusiskin
Copy link
Contributor

@jusiskin jusiskin commented Dec 19, 2023

Problem

The mainline branch has an unreleased change that raises the minimum required version of NodeJS from 14.15.018.0.0 for installing the aws-rfdk NPM package. This becomes a breaking change for RFDK users and they would need to perform a NodeJS migration in order to adopt the new version.

Solution

Instead of an immediate breaking change, this PR deprecates support for NodeJS versions earlier to 18.

  • Users will resume being able to install the next RFDK release on NodeJS >= 14.15.0
  • The RFDK will emit a warning when imported about the deprecation
  • The RFDK 1.3.0 upgrade documentation and README.md have been updated to reflect this adjustment

Testing

Used NodeJS 14.21.3 to deploy the All-In-AWS-Infrastructure-Basic TypeScript example successfully.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@jusiskin jusiskin added dependencies This issue is a problem in a dependency. contribution/core This is a PR that came from AWS. labels Dec 19, 2023
@marofke marofke merged commit 84955d1 into aws:mainline Dec 19, 2023
3 checks passed
@jusiskin jusiskin deleted the deprecate_node_14 branch December 19, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. dependencies This issue is a problem in a dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants