Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test_marker files for integ test components #1167

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

marofke
Copy link
Contributor

@marofke marofke commented Dec 20, 2023

Problem

Integration stack components were still creating 'LaunchTemplateName's that were not unique.

Solution

  • added a cdk.json file to the root of the integ directory, which seemed to apply the feature flag correctly
  • this required me to change the integ/scripts/bash/rfdk-integ-e2e.sh script to look for a test_marker file in each integ test component directory as it was causing issues since the script would try to run tests from the integ root
  • reverted the change to add more information to the Bastion name in the test-tier component as it wasn't needed

Testing

  • figured out how to synthesize locally, confirmed the template names were different (each snippet form a different component):
"launchTemplateName": "RFDKIntegDLTestingTier1703111097634975852BastionLaunchTemplateE58D8C6C",
"launchTemplateName": "RFDKIntegRQTestingTier1703111097634975852BastionLaunchTemplate6734337A",
"launchTemplateName": "RFDKIntegWFTestingTier1703111097634975852BastionLaunchTemplate35EDE82F",
"launchTemplateName": "RFDKIntegWFSTestingTier1703111097634975852BastionLaunchTemplate93E234E7",
"launchTemplateName": "RFDKIntegSMTestingTier1703111097634975852BastionLaunchTemplate0BC146AF",

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Signed-off-by: Caden Marofke <marofke@amazon.com>
Copy link
Contributor

@ddneilson ddneilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to root cause this issue and resolve it, Caden!

@marofke marofke merged commit cb27e13 into mainline Dec 20, 2023
3 checks passed
@marofke marofke deleted the marofke/add-integ-test-markers branch December 20, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants