Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(integ): Add test suites RQ-1 and RQ-2, functional tests for rend… #29

Merged
merged 1 commit into from
Aug 11, 2020
Merged

test(integ): Add test suites RQ-1 and RQ-2, functional tests for rend… #29

merged 1 commit into from
Aug 11, 2020

Conversation

aws-painec
Copy link
Contributor

…er queue in http and https modes

Test suite requires local staged Deadline assets of 10.1.9.2 or higher.

See README for additional instructions on running tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@@ -0,0 +1,10 @@
Name=Sleep
UserName=neilsd
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we okay with this going to GitHub?

Copy link
Contributor Author

@aws-painec aws-painec Aug 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I overlooked that that was in there, will fix by changing the UserName to "TestUser"

Blacklist=
ScheduledStartDateTime=23/06/2020 13:49
OverrideTaskExtraInfoNames=False
MachineName=YWG-9902951751
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same deal. :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing machine name to "TestMachine"

@ddneilson ddneilson self-requested a review August 4, 2020 18:44
@aws-painec aws-painec closed this Aug 6, 2020
@aws-painec
Copy link
Contributor Author

Added various scripting improvements centered around getting/using the cert for authenticating to the render queue and improving the logic for the jest test itself. The repository tests can now use those common files as well, but I will make those changes in my next commit which adds another test suite to those tests.

@aws-painec aws-painec reopened this Aug 6, 2020
Copy link

@gdday gdday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more for the RFDK team - how are you handling PRs? The typical flow I've seen from other Open Source projects is that a PR is created from a feature branch, the feature branch is pulled in, and then that gets merged into mainline.

Is it okay to make a PR that goes straight into mainline?

To @aws-painec: There's a mixture of files in this PR that end in a newline, and files that don't. Can you fix the files that don't (I called out a couple, but there are more!) so that they do. Shell scripts really should end in a newline, it's a POSIX standard (even if most shells have hacks that let them work without one!).

@ddneilson
Copy link
Contributor

This is more for the RFDK team - how are you handling PRs? The typical flow I've seen from other Open Source projects is that a PR is created from a feature branch, the feature branch is pulled in, and then that gets merged into mainline.

Is it okay to make a PR that goes straight into mainline?

Short answer, yes. Long answer: https://github.com/aws/aws-rfdk/blob/mainline/CONTRIBUTING.md#step-5-pull-request

;-)

@gdday
Copy link

gdday commented Aug 7, 2020

Great! We should probably update those instructions to be more explicit about PRs coming to/from mainline, that's unusual for GitHub projects (or, at least, unusual for the projects I've ever submitted PRs for!)

But now I know, and I shall never bring it up again. ;-)

gdday
gdday previously approved these changes Aug 7, 2020
Copy link

@gdday gdday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now. Not all of the .ts files end in a newline, but I'm not going to not approve this because of that.

Thanks for making the changes Claire!

@aws-painec aws-painec requested a review from gdday August 10, 2020 20:14
Copy link

@gdday gdday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I didn't see any issues. Nice!

@aws-painec aws-painec merged commit 0685e71 into aws:mainline Aug 11, 2020
evanspearman-a pushed a commit that referenced this pull request Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants