-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(integ): Add test suites RQ-1 and RQ-2, functional tests for rend… #29
Conversation
@@ -0,0 +1,10 @@ | |||
Name=Sleep | |||
UserName=neilsd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we okay with this going to GitHub?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I overlooked that that was in there, will fix by changing the UserName to "TestUser"
Blacklist= | ||
ScheduledStartDateTime=23/06/2020 13:49 | ||
OverrideTaskExtraInfoNames=False | ||
MachineName=YWG-9902951751 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same deal. :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing machine name to "TestMachine"
integ/components/deadline/renderQueue/scripts/bastion/testing/RQ-fetch-repository-file.sh
Outdated
Show resolved
Hide resolved
integ/components/deadline/renderQueue/scripts/bastion/testing/RQ-query-endpoint.sh
Outdated
Show resolved
Hide resolved
integ/components/deadline/renderQueue/scripts/bastion/testing/RQ-submit-job.sh
Outdated
Show resolved
Hide resolved
integ/components/deadline/renderQueue/scripts/bastion/testing/RQ-test-deadlinecommand.sh
Outdated
Show resolved
Hide resolved
integ/components/deadline/renderQueue/test/deadline-renderQueue.test.ts
Outdated
Show resolved
Hide resolved
Added various scripting improvements centered around getting/using the cert for authenticating to the render queue and improving the logic for the jest test itself. The repository tests can now use those common files as well, but I will make those changes in my next commit which adds another test suite to those tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more for the RFDK team - how are you handling PRs? The typical flow I've seen from other Open Source projects is that a PR is created from a feature branch, the feature branch is pulled in, and then that gets merged into mainline.
Is it okay to make a PR that goes straight into mainline?
To @aws-painec: There's a mixture of files in this PR that end in a newline, and files that don't. Can you fix the files that don't (I called out a couple, but there are more!) so that they do. Shell scripts really should end in a newline, it's a POSIX standard (even if most shells have hacks that let them work without one!).
integ/components/deadline/renderQueue/scripts/bastion/setup/install_jq.sh
Outdated
Show resolved
Hide resolved
Short answer, yes. Long answer: https://github.com/aws/aws-rfdk/blob/mainline/CONTRIBUTING.md#step-5-pull-request ;-) |
Great! We should probably update those instructions to be more explicit about PRs coming to/from mainline, that's unusual for GitHub projects (or, at least, unusual for the projects I've ever submitted PRs for!) But now I know, and I shall never bring it up again. ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good now. Not all of the .ts files end in a newline, but I'm not going to not approve this because of that.
Thanks for making the changes Claire!
integ/components/deadline/common/scripts/bastion/utils/cleanup-cert.sh
Outdated
Show resolved
Hide resolved
…er queue in http and https modes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, I didn't see any issues. Nice!
…er queue in http and https modes (#29)
…er queue in http and https modes
Test suite requires local staged Deadline assets of 10.1.9.2 or higher.
See README for additional instructions on running tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license