feat(deadline): use TLS between RenderQueue and clients by default #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #490 BREAKING CHANGE: Farms currently not configured to use external TLS on the Render Queue will be modified to have it enabled and using the default certificate and hosted zone. To continue to keep external TLS disabled, the `enabled` flag on the `RenderQueueExternalTLSProps` can be set to false; however, we strongly encourage you to enable TLS.
jusiskin
requested changes
Jun 30, 2021
examples/deadline/EC2-Image-Builder/python/package/lib/base_farm_stack.py
Outdated
Show resolved
Hide resolved
kozlove-aws
reviewed
Jul 19, 2021
jusiskin
requested changes
Jul 19, 2021
There was a problem hiding this comment.
This is looking good to me. Only one more request...
Since this is a breaking change, do you mind adding upgrade documentation to packages/aws-rfdk/docs/upgrade like we have for 0.27.0? This should help guide a RFDK user through the process of upgrading and determining whether they need to take any action and if so, what action to take.
jusiskin
reviewed
Jul 19, 2021
examples/deadline/EC2-Image-Builder/python/package/lib/base_farm_stack.py
Outdated
Show resolved
Hide resolved
jusiskin
requested changes
Jul 21, 2021
kozlove-aws
previously approved these changes
Jul 21, 2021
jusiskin
requested changes
Jul 23, 2021
jusiskin
changed the title
kozlove-aws
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #490
BREAKING CHANGE: Farms currently not configured to use external TLS on
the Render Queue will be modified to have it enabled and using the
default certificate and hosted zone. To continue to keep external TLS
disabled, the
enabledflag on theRenderQueueExternalTLSPropscan beset to false; however, we strongly encourage you to enable TLS.
Testing
This has full unit test coverage and was also tested by deploying the render queue and worker fleet integration test suites.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license