Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deadline): Close RenderQueue to ingress traffic by default #51

Merged
merged 1 commit into from
Aug 11, 2020
Merged

fix(deadline): Close RenderQueue to ingress traffic by default #51

merged 1 commit into from
Aug 11, 2020

Conversation

ddneilson
Copy link
Contributor

The RenderQueue's ALB listener currently allows world-ingress, but it should be locked down to allow no ingress by default; with code being explicitly required to allow ingress.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@ddneilson
Copy link
Contributor Author

Note, for reference: https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-ecs-patterns.ApplicationLoadBalancedEc2Service.html#openlistener

jusiskin
jusiskin approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@jusiskin jusiskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Approved

@grbartel grbartel self-requested a review August 11, 2020 17:46
grbartel
grbartel approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@grbartel grbartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@ddneilson ddneilson merged commit f1e7c4b into aws:mainline Aug 11, 2020
@ddneilson ddneilson deleted the rq_no_ingress branch August 13, 2020 19:52
evanspearman-a pushed a commit that referenced this pull request Aug 17, 2020
@ddneilson @evanspearman-a
fix(deadline): Close RenderQueue to ingress traffic by default (#51)
4d540d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jusiskin jusiskin jusiskin approved these changes

@grbartel grbartel grbartel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ddneilson @grbartel @jusiskin