Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deadline): fix issue in client TLS configuration for Deadline 10.1.18.5 #537

Closed

Conversation

jusiskin
Copy link
Contributor

@jusiskin jusiskin commented Aug 17, 2021

Problem

The behavior of the ChangeRepository[SkipValidation] Deadline command in 10.1.18.5 has changed. It now clears the ProxySSLCA setting in deadline.ini before attempting to apply/validate the configuration. RFDK relied on the previous behavior where the ProxySSLCA was left unchanged.

Solution

We cannot use ChangeRepository without supplying a "client certificate" since this will disable TLS. Instead, we have switched from using ChangeRepository to instead use SetIniFileSetting ProxyRoot <RQ_ENDPOINT> . RFDK also relied on having ChangeRepository validate the connection and error if the connection settings were incorrect. We now change that validation to instead run a separate Deadline command to test the connection.

We made the same change to the Deadline configuration script that runs on the RFDK integ tests.

Testing

WIP...

Proposed test plan:

  1. Deploy the All-in-AWS-Basic example app using staged recipes for Deadline 10.1.18.5 and Deadline 10.1.18.5 AWS Portal AMIs. Confirm that the deploy succeeds and Workers are connected properly to Deadline. Repeat for Linux/Windows workers and for pre-10.1.18 Worker AMIs.
  2. Run the RFDK integ tests and confirm they pass for both pre 10.1.18 and 10.1.18.5

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@jusiskin jusiskin added bug This issue is a bug. contribution/core This is a PR that came from AWS. labels Aug 17, 2021
@horsmand
Copy link
Contributor

Closing this as we have this commit updated to fix the integ tests and in a new PR: #543

@horsmand horsmand closed this Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants