Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(deadline): fix VersionQuery docs #631

Merged
merged 2 commits into from
Nov 8, 2021

Conversation

jusiskin
Copy link
Contributor

@jusiskin jusiskin commented Nov 8, 2021

Problem

The docs in the Deadline module's README.md is stale and references some removed APIs (VersionQuery.exact(...) and VersionQuery.exactString(...)) that have since been removed (#175).

Solution

Remove references to the old API and replace with documentation for the new equivalent usages.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Co-authored-by: Jericho Tolentino <68654047+jericht@users.noreply.github.com>
@jusiskin jusiskin requested a review from jericht November 8, 2021 19:59
@horsmand horsmand merged commit 94988f2 into aws:mainline Nov 8, 2021
@jusiskin jusiskin deleted the versionquery_docs_fix branch November 8, 2021 23:20
@jusiskin jusiskin added contribution/core This is a PR that came from AWS. documentation This is a problem with documentation. labels Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. documentation This is a problem with documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants