Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(all): migrate to CDKv2 #738

Merged
merged 1 commit into from
Jul 28, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,6 @@ yarn-error.log

#Defines license that must be present
!license-header.js

# Visual Studio Code working space
.vscode/
13 changes: 0 additions & 13 deletions examples/deadline/All-In-AWS-Infrastructure-Basic/python/cdk.json
Original file line number Diff line number Diff line change
@@ -1,18 +1,5 @@
{
"app": "python -m package.app",
"context": {
"@aws-cdk/aws-apigateway:usagePlanKeyOrderInsensitiveId": true,
"@aws-cdk/core:enableStackNameDuplicates": true,
"aws-cdk:enableDiffNoFail": true,
"@aws-cdk/core:stackRelativeExports": true,
"@aws-cdk/aws-ecr-assets:dockerIgnoreSupport": true,
"@aws-cdk/aws-secretsmanager:parseOwnedSecretName": true,
"@aws-cdk/aws-kms:defaultKeyPolicies": true,
"@aws-cdk/aws-s3:grantWriteWithoutAcl": true,
"@aws-cdk/aws-ecs-patterns:removeDefaultDesiredCount": true,
"@aws-cdk/aws-rds:lowercaseDbIdentifier": true,
"@aws-cdk/aws-efs:defaultEncryptionAtRest": true,
"@aws-cdk/aws-lambda:recognizeVersionProps": true,
"@aws-cdk/aws-cloudfront:defaultSecurityPolicyTLSv1.2_2021": true
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

import os

from aws_cdk.core import (
from aws_cdk import (
App,
Environment
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ def __init__(self):
self.deadline_client_linux_ami_map: Mapping[str, str] = {'us-west-2': 'ami-04ae356533dc07fb5'}

# A secret (in binary form) in SecretsManager that stores the UBL certificates in a .zip file.
# This must be in the format `arn:<partition>:secretsmanager:<region>:<accountId>:secret:<secretName>-<6RandomCharacters`
self.ubl_certificate_secret_arn: str =\
''

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@
Optional
)

from aws_cdk.core import (
Construct,
from aws_cdk import (
Stack,
StackProps
)
Expand All @@ -35,6 +34,9 @@
UsageBasedLicensing,
WorkerInstanceFleet,
)
from constructs import (
Construct
)


from . import subnets
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
# Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
# SPDX-License-Identifier: Apache-2.0

from aws_cdk.core import (
from aws_cdk import (
Stack,
Construct
)

from aws_cdk.aws_ec2 import (
FlowLogDestination,
FlowLogTrafficType,
Expand All @@ -15,10 +13,12 @@
SubnetSelection,
SubnetType
)

from aws_cdk.aws_route53 import (
PrivateHostedZone
)
from constructs import (
Construct
)

from . import subnets

Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
# Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
# SPDX-License-Identifier: Apache-2.0

from aws_cdk.core import (
Construct,
from aws_cdk import (
Stack,
)
from aws_rfdk import (
DistinguishedName,
X509CertificatePem
)
from constructs import (
Construct
)


class SecurityTier(Stack):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@
import typing
from dataclasses import dataclass

from aws_cdk.core import (
Construct,
from aws_cdk import (
Duration,
Stack,
StackProps
Expand All @@ -26,7 +25,6 @@
from aws_cdk.aws_route53 import (
IPrivateHostedZone
)

from aws_rfdk import (
DistinguishedName,
MountableEfs,
Expand All @@ -47,6 +45,10 @@
UsageBasedLicensing,
VersionQuery,
)
from constructs import (
Construct
)


from . import subnets

Expand Down Expand Up @@ -222,7 +224,7 @@ def __init__(self, scope: Construct, stack_id: str, *, props: ServiceTierProps,
if props.ubl_licenses:
if not props.ubl_certs_secret_arn:
raise ValueError('UBL certificates secret ARN is required when using UBL but was not specified.')
ubl_cert_secret = Secret.from_secret_arn(self, 'ublcertssecret', props.ubl_certs_secret_arn)
ubl_cert_secret = Secret.from_secret_complete_arn(self, 'ublcertssecret', props.ubl_certs_secret_arn)
self.ubl_licensing = UsageBasedLicensing(
self,
'UsageBasedLicensing',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@
from dataclasses import dataclass
from typing import Optional

from aws_cdk.core import (
Construct,
from aws_cdk import (
Duration,
RemovalPolicy,
Size,
Expand Down Expand Up @@ -52,7 +51,6 @@
from aws_cdk.aws_sns_subscriptions import (
EmailSubscription
)

from aws_rfdk import (
MongoDbUsers,
MongoDbX509User,
Expand All @@ -67,10 +65,12 @@
X509CertificatePem,
X509CertificatePkcs12
)

from aws_rfdk.deadline import (
DatabaseConnection
)
from constructs import (
Construct
)

from . import subnets

Expand Down Expand Up @@ -231,8 +231,7 @@ def add_low_efs_burst_credit_alarms(self, filesystem: FileSystem, email_address:
'SNSEncryptionKey',
description='Used to encrypt the SNS Topic for sending EFS Burst Credit alerts',
enable_key_rotation=True,
removal_policy=RemovalPolicy.DESTROY,
trust_account_identities=True
kozlove-aws marked this conversation as resolved.
Show resolved Hide resolved
removal_policy=RemovalPolicy.DESTROY
)
key.grant(ServicePrincipal('cloudwatch.amazonaws.com'), 'kms:Decrypt', 'kms:GenerateDataKey')

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
packages=setuptools.find_packages(where="package"),

install_requires=[
"aws-cdk.core==1.160.0",
"aws-cdk-lib==2.33.0",
"aws-rfdk==0.42.0"
],

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

import 'source-map-support/register';
import { config } from './config';
import * as cdk from '@aws-cdk/core';
import * as cdk from 'aws-cdk-lib';
import { NetworkTier } from '../lib/network-tier';
import {
ServiceTier,
Expand All @@ -22,7 +22,7 @@ import {
InstanceSize,
InstanceType,
MachineImage,
} from '@aws-cdk/aws-ec2';
} from 'aws-cdk-lib/aws-ec2';
import { ComputeTier } from '../lib/compute-tier';

// ------------------------------ //
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ class AppConfig {

/**
* (Optional) A secret (in binary form) in SecretsManager that stores the UBL certificates in a .zip file.
* This must be in the format `arn:<partition>:secretsmanager:<region>:<accountId>:secret:<secretName>-<6RandomCharacters`
*/
public readonly ublCertificatesSecretArn?: string;

Expand Down
13 changes: 0 additions & 13 deletions examples/deadline/All-In-AWS-Infrastructure-Basic/ts/cdk.json
Original file line number Diff line number Diff line change
@@ -1,18 +1,5 @@
{
"app": "npx ts-node bin/app.ts",
"context": {
"@aws-cdk/aws-apigateway:usagePlanKeyOrderInsensitiveId": true,
"@aws-cdk/core:enableStackNameDuplicates": true,
"aws-cdk:enableDiffNoFail": true,
"@aws-cdk/core:stackRelativeExports": true,
"@aws-cdk/aws-ecr-assets:dockerIgnoreSupport": true,
"@aws-cdk/aws-secretsmanager:parseOwnedSecretName": true,
"@aws-cdk/aws-kms:defaultKeyPolicies": true,
"@aws-cdk/aws-s3:grantWriteWithoutAcl": true,
"@aws-cdk/aws-ecs-patterns:removeDefaultDesiredCount": true,
"@aws-cdk/aws-rds:lowercaseDbIdentifier": true,
"@aws-cdk/aws-efs:defaultEncryptionAtRest": true,
"@aws-cdk/aws-lambda:recognizeVersionProps": true,
"@aws-cdk/aws-cloudfront:defaultSecurityPolicyTLSv1.2_2021": true
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ import {
IMachineImage,
IVpc,
Port,
} from '@aws-cdk/aws-ec2';
import * as cdk from '@aws-cdk/core';
} from 'aws-cdk-lib/aws-ec2';
import * as cdk from 'aws-cdk-lib';
import {
IHost,
InstanceUserDataProvider,
Expand All @@ -24,7 +24,8 @@ import {
IHealthMonitor,
SessionManagerHelper,
} from 'aws-rfdk';
import { Asset } from '@aws-cdk/aws-s3-assets';
import { Asset } from 'aws-cdk-lib/aws-s3-assets';
import { Construct } from 'constructs';
import * as path from 'path'

import { Subnets } from './subnets';
Expand Down Expand Up @@ -83,7 +84,7 @@ class UserDataProvider extends InstanceUserDataProvider {
host.userData.addCommands('echo postWorkerLaunch');
if (host.node.scope != undefined) {
const testScript = new Asset(
host.node.scope as cdk.Construct,
host.node.scope as Construct,
'SampleAsset',
{path: path.join(__dirname, '..', '..', 'scripts', 'configure_worker.sh')},
);
Expand Down Expand Up @@ -120,7 +121,7 @@ export class ComputeTier extends cdk.Stack {
* @param id The ID of this construct.
* @param props The properties of this construct.
*/
constructor(scope: cdk.Construct, id: string, props: ComputeTierProps) {
constructor(scope: Construct, id: string, props: ComputeTierProps) {
super(scope, id, props);

this.healthMonitor = new HealthMonitor(this, 'HealthMonitor', {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,12 @@ import {
SubnetSelection,
SubnetType,
Vpc,
} from '@aws-cdk/aws-ec2';
} from 'aws-cdk-lib/aws-ec2';
import {
PrivateHostedZone,
} from '@aws-cdk/aws-route53';
import * as cdk from '@aws-cdk/core';
} from 'aws-cdk-lib/aws-route53';
import * as cdk from 'aws-cdk-lib';
import { Construct } from 'constructs';

import { Subnets } from './subnets';

Expand Down Expand Up @@ -67,7 +68,7 @@ export class NetworkTier extends cdk.Stack {
* @param id The ID of this construct.
* @param props The stack properties.
*/
constructor(scope: cdk.Construct, id: string, props?: cdk.StackProps) {
constructor(scope: Construct, id: string, props?: cdk.StackProps) {
super(scope, id, props);

this.vpc = new Vpc(this, 'Vpc', {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@
* SPDX-License-Identifier: Apache-2.0
*/

import * as cdk from '@aws-cdk/core';
import * as cdk from 'aws-cdk-lib';
import {
X509CertificatePem,
} from 'aws-rfdk';
import { Construct } from 'constructs';

/**
* The security tier of the render farm. This stack contains resources used to
Expand All @@ -24,7 +25,7 @@ export class SecurityTier extends cdk.Stack {
* @param id The ID of this construct.
* @param props The properties for the security tier.
*/
constructor(scope: cdk.Construct, id: string, props: cdk.StackProps) {
constructor(scope: Construct, id: string, props: cdk.StackProps) {
super(scope, id, props);

this.rootCa = new X509CertificatePem(this, 'RootCA', {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ import {
BastionHostLinux,
BlockDeviceVolume,
IVpc,
} from '@aws-cdk/aws-ec2';
} from 'aws-cdk-lib/aws-ec2';
import {
ApplicationProtocol,
} from '@aws-cdk/aws-elasticloadbalancingv2';
} from 'aws-cdk-lib/aws-elasticloadbalancingv2';
import {
IPrivateHostedZone,
} from '@aws-cdk/aws-route53';
import * as cdk from '@aws-cdk/core';
} from 'aws-cdk-lib/aws-route53';
import * as cdk from 'aws-cdk-lib';
import {
MountableEfs,
X509CertificatePem,
Expand All @@ -31,8 +31,9 @@ import {
} from 'aws-rfdk/deadline';
import {
Secret,
} from '@aws-cdk/aws-secretsmanager';
} from 'aws-cdk-lib/aws-secretsmanager';
import { SessionManagerHelper } from 'aws-rfdk/lib/core';
import { Construct } from 'constructs';

import { Subnets } from './subnets';

Expand Down Expand Up @@ -130,7 +131,7 @@ export class ServiceTier extends cdk.Stack {
* @param id The ID of this construct.
* @param props The properties for this construct.
*/
constructor(scope: cdk.Construct, id: string, props: ServiceTierProps) {
constructor(scope: Construct, id: string, props: ServiceTierProps) {
super(scope, id, props);

// Bastion instance for convenience (e.g. SSH into RenderQueue and WorkerFleet instances).
Expand Down
Loading