-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deadline): update to Deadline licensing terms #742
Conversation
New revision incoming. This is a breaking change, but I neglected to indicate as such in the commit message. It's important for the ChangeLog. |
031d5d7
to
2dc08db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple suggestions.
examples/deadline/All-In-AWS-Infrastructure-Basic/ts/bin/config.ts
Outdated
Show resolved
Hide resolved
packages/aws-rfdk/lib/deadline/test/thinkbox-docker-images.test.ts
Outdated
Show resolved
Hide resolved
2dc08db
to
c2941c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some more comments similar that were fixed.
packages/aws-rfdk/lib/deadline/lib/configure-spot-event-plugin.ts
Outdated
Show resolved
Hide resolved
d4f8f8a
to
cd5f3af
Compare
BREAKING CHANGE: The `userAwsThinkboxEulaAcceptance` property of the `ThinkboxDockerImages` construct has been removed and replaced with `userAwsCustomerAgreementAndIpLicenseAcceptance`. The licensing terms of Deadline have been retroactively changed with the release of Deadline 10.1.23, and these new terms must be agreed to by a code change in your applications.
cd5f3af
to
395d48d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BREAKING CHANGE: The
userAwsThinkboxEulaAcceptance
property of theThinkboxDockerImages
construct has been removed and replaced with
userAwsCustomerAgreementAndIpLicenseAcceptance
.The licensing terms of Deadline have been retroactively changed with the
release of Deadline 10.1.23, and these new terms must be agreed to by a
code change in your applications.
Note: The BREAKING CHANGE text as it appears in the commit will appear in the release notes / ChangeLog.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license