Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add GitHub links to changelogs #84

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

jusiskin
Copy link
Contributor

Change

This change removes the configuration in package.json that caused the "(Link not implemented)" to be generated in our CHANGELOG.md file when creating a new release.

Removing the configuration causes standard-version to automatically generate hyperlinks to the GitHub commits.

Testing

Ran the ./bump.sh script and previewed the rendered CHANGELOG.md markdown in VSCode. All hyperlinks work as expected


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@jusiskin jusiskin added the contribution/core This is a PR that came from AWS. label Aug 26, 2020
@ddneilson ddneilson self-requested a review August 27, 2020 18:47
@horsmand horsmand merged commit dc0c6f1 into aws:mainline Aug 27, 2020
@jusiskin jusiskin deleted the changelog_links branch August 31, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants