Update all cookiecutter.json files to add _copy_without_render#258
Merged
hawflau merged 1 commit intoaws:masterfrom Jun 16, 2022
Merged
Update all cookiecutter.json files to add _copy_without_render#258hawflau merged 1 commit intoaws:masterfrom
hawflau merged 1 commit intoaws:masterfrom
Conversation
mildaniel
reviewed
Jun 16, 2022
| "architectures": { | ||
| "value": [] | ||
| } | ||
| }, |
Contributor
There was a problem hiding this comment.
Unrelated to this PR but what do we normally do with deprecated runtime templates?
Contributor
Author
There was a problem hiding this comment.
We just remove the entire directory
mildaniel
approved these changes
Jun 16, 2022
This was referenced Jul 27, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
The newline handling logic introduced in cookiecutter v2+ broke SAM CLI as we tried to bump it in lieu of a CVE in cookiecutter (See SAM CLI PR). The particular file breaking cookiecutter is
.gitignore, in which Python detects multiple linebreak characters, instead of single.We need to fix this so we can bump the cookiecutter version in SAM CLI.
Description of changes:
As the
.gitignorefiles don't really need to be rendered by cookiecutter, we add the_copy_without_renderconfig into thecookiecutter.jsonfiles, so cookiecutter in SAM CLI will skip rendering the.gitignorefiles.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.