ImportError: cannot import name 'soft_unicode' from 'markupsafe' in Release 1.38.0 #3661

SamkeetJainMensa · 2022-02-18T05:43:35Z

I'm building the sam project on github action and since the upgrade of sam-cli to 1.38.0, i'm getting following error when i build project

Python version: 3.10.2 & 3.8.12 (Tried both versions)
Pip version: pip-22.0.3
Sam cli version: 1.38.0

Command: sam build --template ${SAM_TEMPLATE} --use-container

Trace:

Traceback (most recent call last):
  File "/home/runner/work/_temp/setup-sam-43osIE/bin/sam", line 8, in <module>
    sys.exit(cli())
  File "/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/click/core.py", line 8[29](https://github.com/mensabrands/dip-app/runs/5243143255?check_suite_focus=true#step:5:29), in __call__
    return self.main(*args, **kwargs)
  File "/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/click/decorators.py", line 73, in new_func
    return ctx.invoke(f, obj, *args, **kwargs)
  File "/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/samcli/lib/telemetry/metric.py", line 166, in wrapped
    raise exception  # pylint: disable=raising-bad-type
  File "/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/samcli/lib/telemetry/metric.py", line 124, in wrapped
    return_value = func(*args, **kwargs)
  File "/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/samcli/lib/utils/version_checker.py", line 41, in wrapped
    actual_result = func(*args, **kwargs)
  File "/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/samcli/cli/main.py", line 87, in wrapper
    return func(*args, **kwargs)
  File "/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/samcli/commands/build/command.py", line 174, in cli
    do_cli(
  File "/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/samcli/commands/build/command.py", line 220, in do_cli
    from samcli.commands.build.build_context import BuildContext
  File "/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/samcli/commands/build/build_context.py", line 13, in <module>
    from samcli.lib.providers.sam_api_provider import SamApiProvider
  File "/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/samcli/lib/providers/sam_api_provider.py", line 6, in <module>
    from samcli.lib.providers.api_collector import ApiCollector
  File "/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/samcli/lib/providers/api_collector.py", line 10, in <module>
    from samcli.local.apigw.local_apigw_service import Route
  File "/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/samcli/local/apigw/local_apigw_service.py", line 11, in <module>
    from flask import Flask, request
  File "/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/flask/__init__.py", line 14, in <module>
    from jinja2 import escape
  File "/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/jinja2/__init__.py", line 12, in <module>
    from .environment import Environment
  File "/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/jinja2/environment.py", line 25, in <module>
    from .defaults import BLOCK_END_STRING
  File "/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/jinja2/defaults.py", line 3, in <module>
    from .filters import FILTERS as DEFAULT_FILTERS  # noqa: F[40](https://github.com/mensabrands/dip-app/runs/5243143255?check_suite_focus=true#step:5:40)1
  File "/home/runner/work/_temp/setup-sam-[43](https://github.com/mensabrands/dip-app/runs/5243143255?check_suite_focus=true#step:5:43)osIE/.venv/lib/python3.10/site-packages/jinja2/filters.py", line 13, in <module>
    from markupsafe import soft_unicode
ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/markupsafe/__init__.py)

I revert sam-cli version to 1.37.0 and it worked perfectly.

The text was updated successfully, but these errors were encountered:

SamkeetJainMensa · 2022-02-18T06:04:03Z

Looks the issue is due to upgrade in MarkupSafe:2.1.0 where they have removed soft_unicode.
Release note: https://markupsafe.palletsprojects.com/en/2.1.x/changes/#version-2-1-0

sam-cli:1.37.0 is downloading MarkupSafe:2.0.1 and sam-cli:1.38.0 is downloading MarkupSafe:2.1.0.

echaoeoen · 2022-02-18T07:01:19Z

I tried to change the version of sam to 1.29.0 in github actions using this action, seemslike it still download the newest version of Markupsafe

olmolod · 2022-02-18T08:42:36Z

same here - seems MarkUoSafe was updated and there is no soft_unicode there any more. How to solve this?

`- step: &build_stage
            name: build
            image: python:3.9
            script:
                - apt-get update && apt-get install -y python3-pip zip 
                - pip install -U awscli
                - aws --version
                - aws configure set default.region $AWS_DEFAULT_REGION
                - aws configure set aws_access_key_id "$AWS_ACCESS_KEY_ID_STAGE"
                - aws configure set aws_secret_access_key "$AWS_SECRET_ACCESS_KEY_STAGE"
                - pip install --user --upgrade aws-sam-cli
                - ln -s /root/.local/bin/sam /usr/bin/sam
                - sam --version
                - sam build`

pip install --user --upgrade aws-sam-cli - gets last version on Jijnja

Collecting Jinja2<4.0.0,>=2.7
Using cached Jinja2-3.0.3-py3-none-any.whl (133 kB)

yesterday was
Collecting Jinja2<4.0.0,>=2.7
Using cached Jinja2-2.11.3-py2.py3-none-any.whl (125 kB)

sthadapradit · 2022-02-18T09:10:50Z

@SamkeetJainMensa, thanks lot, it's working with 1.37.0, I did this change in gitaction

  - uses: aws-actions/setup-sam@v1
    with:
      version: 1.37.0

olmolod · 2022-02-18T09:14:05Z

@sthadapradit this I did, but it is temproary solution - any idea how to come back to
pip install --user --upgrade aws-sam-cli
insted
pip install --user aws-sam-cli ==1.37.0

BCarley · 2022-02-18T10:37:55Z

Looks like a breaking change in markupsafe and jinja not specifying an upper version bound pallets/markupsafe#286

Yop-La · 2022-02-18T10:38:37Z

I'm getting the same error with "SAM CLI, version 1.37.0". I have not upgraded.

MurphyAdam · 2022-02-18T10:39:12Z

I had this issue with Django using Jinja2. Jinja2 imports soft_unicode from the package causing it to break.

Yop-La · 2022-02-18T11:00:40Z

Downgrading markupsafe to 2.0.1 fixes the issue on my side.
pip install markupsafe==2.0.1

davidism · 2022-02-18T14:12:03Z

aws-sam-cli is using an unsupported version of Jinja, they need to update to the latest version. Additionally, they need to read https://hynek.me/articles/semver-will-not-save-you/, then use a tool like pip-tools to pin their dependencies to control when their users get updates. Be sure to run tests with deprecation warnings treated as errors so that these types of changes show up early.

* fix issue * test and build in CI * minor * typo * fix for aws/aws-sam-cli#3661 * exec permission for container-release.sh * multi-arch docker image build required

jfuss · 2022-02-18T16:29:25Z

Looking into this. Though this is why we do not recommend using pip to install and instead use our installers.

@davidism We are stuck in a place that if we pin, customers get upset that they can install with all their other tools (in a single interpreter instead of isolating). If we don't pin (everything), we run into this things. So it's a who do we block/make angry situation. Would be great if python (pip) actually solved this instead of each tool having to battle users on how to install or providing ways tools can vend safely through pip.

codybc · 2022-02-18T19:14:35Z

Just ran into this issue installing with aws-actions/setup-sam@v1

easy fix if anyone else sees this though, setup-sam allows you to set version

- uses: aws-actions/setup-sam@v1
   with:
     version: 1.37.0

Update 05.use-cases-c.md

mndeveci · 2022-02-19T00:14:05Z

Thanks for reporting this issue. SAM CLI v1.38.1 is released which contains the fix for it. As @jfuss mentioned, we would highly recommend using our installers (NativeInstaller for Linux, brew for MacOS and MSI for Windows).

Resolving the issue.

Pins the version to 2.0.1. aws/aws-sam-cli#3661 (comment)

Amanrajdas01 · 2022-07-14T19:38:27Z

same here - seems MarkUoSafe was updated and there is no soft_unicode there any more. How to solve this?
`- step: &build_stage
            name: build
            image: python:3.9
            script:
                - apt-get update && apt-get install -y python3-pip zip 
                - pip install -U awscli
                - aws --version
                - aws configure set default.region $AWS_DEFAULT_REGION
                - aws configure set aws_access_key_id "$AWS_ACCESS_KEY_ID_STAGE"
                - aws configure set aws_secret_access_key "$AWS_SECRET_ACCESS_KEY_STAGE"
                - pip install --user --upgrade aws-sam-cli
                - ln -s /root/.local/bin/sam /usr/bin/sam
                - sam --version
                - sam build`
pip install --user --upgrade aws-sam-cli - gets last version on Jijnja

Collecting Jinja2<4.0.0,>=2.7 Using cached Jinja2-3.0.3-py3-none-any.whl (133 kB)

yesterday was Collecting Jinja2<4.0.0,>=2.7 Using cached Jinja2-2.11.3-py2.py3-none-any.whl (125 kB)

thankyou, it works

下記と同じようにImportErrorが発生したため aws/aws-sam-cli#3661

Pinning markupsafe, see aws/aws-sam-cli#3661

### What changes were proposed in this pull request? This PR proposes to pin the Python package `markupsafe` to 2.0.1 to fix the CI failure as below. ``` ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/home/runner/work/_temp/setup-sam-43osIE/.venv/lib/python3.10/site-packages/markupsafe/__init__.py) ``` Since `markupsafe==2.1.0` has removed `soft_unicode`, `from markupsafe import soft_unicode` no longer working properly. See aws/aws-sam-cli#3661 for more detail. ### Why are the changes needed? To fix the CI failure on branch-3.2 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The existing tests are should be passed Closes apache#35602 from itholic/SPARK-38279. Authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>

refer to aws/aws-sam-cli#3661 for similar issue

SamarShabanCS · 2022-10-04T05:01:29Z

Downgrading markupsafe to 2.0.1 fixes the issue on my side. pip install markupsafe==2.0.1

Thanks a lot.
It solved the problem

Fix issue aws/aws-sam-cli#3661 Downgrade markupsafe to 2.0.1

See aws/aws-sam-cli#3661

Add the constraint of markupsafe version to 2.0.1, according to the ref: aws/aws-sam-cli#3661 (comment)

Add the constraint of markupsafe version to 2.0.1, according to the ref: aws/aws-sam-cli#3661 (comment) Add a snapshot of version 2.2.3's Dockerfile

aws/aws-sam-cli#3661

fpena06 · 2023-06-23T14:46:13Z

Downgrading markupsafe to 2.0.1 fixes the issue on my side. pip install markupsafe==2.0.1

thank you.

galigalikun mentioned this issue Feb 18, 2022

ImportError: cannot import name 'soft_unicode' from 'markupsafe' aws-actions/setup-sam#41

Closed

gabelton mentioned this issue Feb 18, 2022

TP2000-143: 500 on Measure Detail view uktrade/tamato#497

Merged

crsib mentioned this issue Feb 18, 2022

Unit testing audacity/audacity#2536

Merged

6 tasks

treff7es mentioned this issue Feb 18, 2022

fix(python build): Pinning markupsafe datahub-project/datahub#4188

Merged

4 tasks

pllim mentioned this issue Feb 18, 2022

ImportError: cannot import name 'soft_unicode' from 'markupsafe' pallets/jinja#1593

Closed

pllim mentioned this issue Feb 18, 2022

TST: devdeps broken due to jinja2 and markupsafe conflicts astropy/astrowidgets#151

Closed

konstan added a commit to nuvla/kafka-notify that referenced this issue Feb 18, 2022

fix for aws/aws-sam-cli#3661

fdf1da7

shibukazu mentioned this issue Feb 18, 2022

"soft_unicode" is not supported in latest markupsafe kyuridenamida/atcoder-tools#263

Open

jasonoma-aws mentioned this issue Feb 18, 2022

ImportError: cannot import name 'json' from 'itsdangerous' (/usr/local/lib/python3.8/dist-packages/itsdangerous/__init__.py) aws-samples/amazon-ecs-mythicalmysfits-workshop#49

Open

jfuss mentioned this issue Feb 18, 2022

fix: Pin MarkupSafe to 2.0.1 #3662

Merged

8 tasks

moelasmar added the type/bug label Feb 18, 2022

adonath mentioned this issue Feb 18, 2022

Minor modifs in environment and .gitignore gammapy/gammapy-v1.0-paper#22

Merged

dianeschulze mentioned this issue Feb 18, 2022

Pin markupsafe==2.0.1 etsy/boundary-layer#131

Merged

dandhlee mentioned this issue Feb 18, 2022

The build failed GoogleCloudPlatform/python-docs-samples#7479

Closed

emmajhudgins referenced this issue in SORTEE-Github-Hackathon/manuscript Feb 18, 2022

Merge pull request #100 from SORTEE-Github-Hackathon/RCO-fixes-brackets

baa8450

Update 05.use-cases-c.md

travisbenedict mentioned this issue Feb 18, 2022

[BUG] OpenSearch Benchmark failing to run after installation because of Markupsafe versioning opensearch-project/opensearch-benchmark#111

Closed

cdoyle-temple added a commit to tulibraries/ansible-role-server-bootstrap that referenced this issue Jul 14, 2022

MarkupSafe deprecation fix

cba3f53

Pins the version to 2.0.1. aws/aws-sam-cli#3661 (comment)

cdoyle-temple mentioned this issue Jul 14, 2022

MarkupSafe deprecation fix tulibraries/ansible-role-server-bootstrap#49

Closed

tetsuya-ki added a commit to tetsuya-ki/discord-reminderbot that referenced this issue Jul 31, 2022

markupsafeを"2.0.1"に固定

807b9b0

下記と同じようにImportErrorが発生したため aws/aws-sam-cli#3661

AlexMikhalev added a commit to AlexMikhalev/automation-api-examples that referenced this issue Aug 3, 2022

Update requirements.txt

b08c12d

Pinning markupsafe, see aws/aws-sam-cli#3661

AlexMikhalev mentioned this issue Aug 3, 2022

Update requirements.txt pulumi/automation-api-examples#36

Merged

jacobcmoxley mentioned this issue Aug 22, 2022

Issue with markupsafe version onionshare/onionshare#1611

Closed

fushar pushed a commit to ioi/cms that referenced this issue Aug 28, 2022

fix: pin MarkupSafe to 2.0.1

7730566

refer to aws/aws-sam-cli#3661 for similar issue

danielsitnik mentioned this issue Aug 28, 2022

Multiple problems with the SQS implementation and documentation up9inc/mockintosh#176

Open

fushar pushed a commit to ioi/cms that referenced this issue Aug 30, 2022

fix: pin MarkupSafe to 2.0.1

527ab03

refer to aws/aws-sam-cli#3661 for similar issue

HuJK added a commit to HuJK/Code-Server-Hub that referenced this issue Oct 4, 2022

fix issue

4829ca3

Fix issue aws/aws-sam-cli#3661 Downgrade markupsafe to 2.0.1

whd mentioned this issue Oct 18, 2022

Delete etl-graph job mozilla/docker-etl#86

Merged

3 tasks

xwang233 mentioned this issue Oct 29, 2022

Got dependency issue with spacy and markupsafe pytorch/benchmark#1269

Closed

Craeckie added a commit to Craeckie/matrix-registration that referenced this issue Nov 4, 2022

Fixed import error of flask caused by markupsafe

4a8af89

See aws/aws-sam-cli#3661

xgui3783 mentioned this issue Nov 18, 2022

Update URL and version of flake8 HumanBrainProject/hbp-spatial-backend#3

Open

hrak mentioned this issue Jan 18, 2023

Cannot import name 'soft_unicode' from 'markupsafe' elastic/ecs#2142

Closed

rbarry82 mentioned this issue Jan 19, 2023

Define all dependences in requirements files canonical/operator#894

Merged

Huge mentioned this issue Jan 30, 2023

The example code fails after installation, MarkupSafe version does not match promptslab/Promptify#9

Closed

jeremyherbert mentioned this issue Feb 3, 2023

ImportError: cannot import name 'soft_unicode' from 'markupsafe' GlasgowEmbedded/glasgow#301

Closed

upadhyeammit mentioned this issue Mar 9, 2023

RHIROS-987 - upgrade flask,werkzeug to newer versions RedHatInsights/ros-backend#301

Merged

9 tasks

crystaldust added a commit to crystaldust/airflow-jobs that referenced this issue Mar 20, 2023

Update the airflow version to 2.5.2(py3.8) in Dockerfile.

84db40f

Add the constraint of markupsafe version to 2.0.1, according to the ref: aws/aws-sam-cli#3661 (comment)

crystaldust mentioned this issue Mar 20, 2023

Update the airflow version to 2.5.2(py3.8) in Dockerfile. oss-know/airflow-jobs#167

Merged

baztian added a commit to baztian/ansible-aws that referenced this issue Mar 24, 2023

Fix sam cli

967c408

aws/aws-sam-cli#3661

baztian mentioned this issue Mar 24, 2023

Fix sam cli baztian/ansible-aws#22

Merged

IanButterworth mentioned this issue Aug 26, 2023

Bump werkzeug from 1.0.1 to 2.2.3 JuliaRegistries/TagBot#257

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ImportError: cannot import name 'soft_unicode' from 'markupsafe' in Release 1.38.0 #3661

ImportError: cannot import name 'soft_unicode' from 'markupsafe' in Release 1.38.0 #3661

SamkeetJainMensa commented Feb 18, 2022 •

edited

Loading

SamkeetJainMensa commented Feb 18, 2022

echaoeoen commented Feb 18, 2022 •

edited

Loading

olmolod commented Feb 18, 2022 •

edited

Loading

sthadapradit commented Feb 18, 2022

olmolod commented Feb 18, 2022

BCarley commented Feb 18, 2022

Yop-La commented Feb 18, 2022 •

edited

Loading

MurphyAdam commented Feb 18, 2022

Yop-La commented Feb 18, 2022 •

edited

Loading

davidism commented Feb 18, 2022

jfuss commented Feb 18, 2022

codybc commented Feb 18, 2022 •

edited

Loading

mndeveci commented Feb 19, 2022

Amanrajdas01 commented Jul 14, 2022

SamarShabanCS commented Oct 4, 2022

fpena06 commented Jun 23, 2023

ImportError: cannot import name 'soft_unicode' from 'markupsafe' in Release 1.38.0 #3661

ImportError: cannot import name 'soft_unicode' from 'markupsafe' in Release 1.38.0 #3661

Comments

SamkeetJainMensa commented Feb 18, 2022 • edited Loading

SamkeetJainMensa commented Feb 18, 2022

echaoeoen commented Feb 18, 2022 • edited Loading

olmolod commented Feb 18, 2022 • edited Loading

sthadapradit commented Feb 18, 2022

olmolod commented Feb 18, 2022

BCarley commented Feb 18, 2022

Yop-La commented Feb 18, 2022 • edited Loading

MurphyAdam commented Feb 18, 2022

Yop-La commented Feb 18, 2022 • edited Loading

davidism commented Feb 18, 2022

jfuss commented Feb 18, 2022

codybc commented Feb 18, 2022 • edited Loading

mndeveci commented Feb 19, 2022

Amanrajdas01 commented Jul 14, 2022

SamarShabanCS commented Oct 4, 2022

fpena06 commented Jun 23, 2023

SamkeetJainMensa commented Feb 18, 2022 •

edited

Loading

echaoeoen commented Feb 18, 2022 •

edited

Loading

olmolod commented Feb 18, 2022 •

edited

Loading

Yop-La commented Feb 18, 2022 •

edited

Loading

Yop-La commented Feb 18, 2022 •

edited

Loading

codybc commented Feb 18, 2022 •

edited

Loading