WIP: Implemented support for CORS in start-api command#1009
Closed
devoto13 wants to merge 1 commit intoaws:developfrom
Closed
WIP: Implemented support for CORS in start-api command#1009devoto13 wants to merge 1 commit intoaws:developfrom
devoto13 wants to merge 1 commit intoaws:developfrom
Conversation
Author
|
Just a short updated on this. I've used Then the implementation will add a new |
Author
|
I switched to another project and won't have time to move this forward in the near future, so closing the PR. There is a decent workaround described in #323 (comment). |
viksrivat
added a commit
to viksrivat/aws-sam-cli
that referenced
this pull request
Jun 26, 2019
… feature/cors_support Add cors support using aws#1009 as a ref
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#323
Description of changes:
This adds a basic support for CORS in
start-apicommand. Currently it only understands format specified in SAM and doesn't understand explicit definition withx-amazon-apigateway-integrationwithtype=mock. I believe that this should solve most of the use cases and support for the explicit specification can be added at the later stage as it is a more complex task.At this stage I'm looking for the confirmation that the direction is right and if so I'll proceed with a cleanup, tests and documentation.
Checklist:
make prpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.